From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] utilities: add helper functions for safe 64-bit integer operations as 32-bit halves Date: Sun, 22 Apr 2007 13:35:56 +0100 Message-ID: <20070422123556.GA28850@infradead.org> References: <20070420123041.94aac1e1.akpm@linux-foundation.org> <1177100459.3718.45.camel@mulgrave.il.steeleye.com> <20070420141218.a0222472.akpm@linux-foundation.org> <20070421030825.bed0b8a9.akpm@linux-foundation.org> <20070421220147.7144113e@the-village.bc.nu> <20070421140622.dc197b38.akpm@linux-foundation.org> <20070422091816.GC1558@infradead.org> <20070422133823.4bd3eaed@the-village.bc.nu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:56177 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030512AbXDVMgN (ORCPT ); Sun, 22 Apr 2007 08:36:13 -0400 Content-Disposition: inline In-Reply-To: <20070422133823.4bd3eaed@the-village.bc.nu> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Alan Cox Cc: Christoph Hellwig , Andrew Morton , "John Anthony Kazos Jr." , James Bottomley , "Cameron, Steve" , "Miller, Mike (OS Dev)" , Hisashi Hifumi , jens.axboe@oracle.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, trivial@kernel.org On Sun, Apr 22, 2007 at 01:38:23PM +0100, Alan Cox wrote: > > > > over-engineering. Call it sector_upper32() do it the simple way and stop > > > > trying to solve a problem we don't have > > > > > > James said we have the same problem with dma_addr_t. > > > > Yes. It's in fact the far more common case and we have a bread of > > macros dealing with the issue in various drivers. > > So we still only need it for unsigned 32/64bit values ? Yes.