All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: Fix potential overflow in perfctr reservation
Date: Sun, 22 Apr 2007 14:14:32 +0200	[thread overview]
Message-ID: <200704221414.32946.ak@suse.de> (raw)
In-Reply-To: <20070422010917.6427e7a2.akpm@linux-foundation.org>


> 
> The created a warning storm:

Hmm, yes good idea to fix that. Probably for x86-64 too.

> 
> I worry rather a lot about how well runtime tested this very late change
> was, 

I tested it with oprofile and checked the nmi watchdog.

> and whether it works correctly even with this fix applied.  Perhaps 
> we should jsut revert?

Then you get the memory corruption back.

The change really only enlarges the bitmaps a little anyways, it does not
change any algorithms.

-Andi
 
 


  reply	other threads:[~2007-04-22 12:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200704172359.l3HNxAMV024586@hera.kernel.org>
2007-04-22  8:09 ` [PATCH] x86: Fix potential overflow in perfctr reservation Andrew Morton
2007-04-22 12:14   ` Andi Kleen [this message]
2007-04-23  5:11   ` YOSHIFUJI Hideaki / 吉藤英明

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200704221414.32946.ak@suse.de \
    --to=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.