From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965379AbXDVTRB (ORCPT ); Sun, 22 Apr 2007 15:17:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965641AbXDVTRB (ORCPT ); Sun, 22 Apr 2007 15:17:01 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:50502 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965379AbXDVTRA (ORCPT ); Sun, 22 Apr 2007 15:17:00 -0400 Date: Sun, 22 Apr 2007 20:16:47 +0100 From: Christoph Hellwig To: "Eric W. Biederman" Cc: ", containers@lists.osdl.org, Oleg Nesterov , Christoph Hellwig , linux-kernel@vger.kernel.org, Benjamin Herrenschmidt Subject: Re: [PATCH] macintosh/therm_pm72.c: Convert to kthread API. Message-ID: <20070422191647.GA14995@infradead.org> Mail-Followup-To: Christoph Hellwig , "Eric W. Biederman" , ", containers@lists.osdl.org, Oleg Nesterov , linux-kernel@vger.kernel.org, Benjamin Herrenschmidt References: <11769695832169-git-send-email-ebiederm@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11769695832169-git-send-email-ebiederm@xmission.com> User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 19, 2007 at 01:58:47AM -0600, Eric W. Biederman wrote: > From: Eric W. Biederman > > This patch modifies startup of the kfand to use kthread_run > not a combination of kernel_thread and daemonize, making > the code a little simpler and more maintaintable. Why is this driver using a thread at all? It's only doing a bunch of rather short-lived things in the thread.