From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030862AbXDVUR2 (ORCPT ); Sun, 22 Apr 2007 16:17:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030870AbXDVUR2 (ORCPT ); Sun, 22 Apr 2007 16:17:28 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:60820 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030862AbXDVUR1 (ORCPT ); Sun, 22 Apr 2007 16:17:27 -0400 Date: Sun, 22 Apr 2007 21:17:09 +0100 From: Christoph Hellwig To: "Eric W. Biederman" Cc: ", containers@lists.osdl.org, Oleg Nesterov , Christoph Hellwig , linux-kernel@vger.kernel.org, Swen Schillig Subject: Re: [PATCH] s390/scsi/zfcp_erp: Convert to use the kthread API Message-ID: <20070422201709.GA23015@infradead.org> Mail-Followup-To: Christoph Hellwig , "Eric W. Biederman" , ", containers@lists.osdl.org, Oleg Nesterov , linux-kernel@vger.kernel.org, Swen Schillig References: <1176969571980-git-send-email-ebiederm@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1176969571980-git-send-email-ebiederm@xmission.com> User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 19, 2007 at 01:58:42AM -0600, Eric W. Biederman wrote: > From: Eric W. Biederman > > Modify zfcperp%s to be started with kthread_run not > a combination of kernel_thread, daemonize and siginitsetinv > making the code slightly simpler and more maintainable. This driver would also benefit from a full kthread conversion. Unfortunately it has a strange dual-use semaphore (->erp_ready_sem) that hinders a straight conversion. Maybe the maintainer can take a look whether there's a nice way to get rid of that one?