From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs-dev <xfs-dev@sgi.com>,
xfs-oss <xfs@oss.sgi.com>
Subject: Re: review [1 of 3]: lazy superblock counters - core kernel
Date: Mon, 23 Apr 2007 23:23:40 +0100 [thread overview]
Message-ID: <20070423222340.GA23870@infradead.org> (raw)
In-Reply-To: <20070423221622.GL32602149@melbourne.sgi.com>
On Tue, Apr 24, 2007 at 08:16:23AM +1000, David Chinner wrote:
> > > + INT_SET(sb->sb_fdblocks, ARCH_CONVERT, mp->m_sb.sb_fdblocks);
> > > + XFS_SB_UNLOCK(mp, s);
> >
> > This is really quite nasty. Should we at least force a cache flush here?
>
> Well, that is what it's doing - xfs_log_sbcount() flushes the counters and
> logs the changes to the superblock. If that fails (very rare) we've already
> got the current values in mp->m_sb and so all we need to do is push them
> into the disk superblock and write it.
Sorry, should have been more detailed. I meant the disk cache, as in
blkdev_issue_flush, to make sure the data hits the disk, even if it doesn't
go through a transaction which would normally do that. (in the barriers case)
next prev parent reply other threads:[~2007-04-23 22:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-19 23:15 review [1 of 3]: lazy superblock counters - core kernel David Chinner
2007-04-23 22:00 ` Christoph Hellwig
2007-04-23 22:16 ` David Chinner
2007-04-23 22:23 ` Christoph Hellwig [this message]
2007-04-23 23:20 ` David Chinner
2007-04-24 1:28 ` David Chinner
2007-04-24 8:51 ` Christoph Hellwig
2007-04-24 14:16 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070423222340.GA23870@infradead.org \
--to=hch@infradead.org \
--cc=dgc@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.