From: "Shawn O. Pearce" <spearce@spearce.org>
To: "Uwe Kleine-König" <ukleinek@informatik.uni-freiburg.de>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [BUG] git gui and my ö
Date: Tue, 24 Apr 2007 02:16:52 -0400 [thread overview]
Message-ID: <20070424061652.GP17480@spearce.org> (raw)
In-Reply-To: <20070424053935.GO17480@spearce.org>
"Shawn O. Pearce" <spearce@spearce.org> wrote:
> Uwe Kleine-K??nig <ukleinek@informatik.uni-freiburg.de> wrote:
> > commit-tree failed:
> > Warning: commit message does not conform to UTF-8.
This was starting to bug me, so I went off and found it. OK, well
the encoding error anyway. git-gui incorrectly claimed commit-tree
failed when it didn't. But besides the point, this is the bad line:
> 1294 fconfigure $msg_wt -encoding $enc -translation binary
I have had trouble in the past with trying to use that magic
-encoding flag on fconfigure to get Tcl's file channels to perform
encoding work for me. Seems it doesn't work right or something...
so other parts of git-gui (e.g. the filename handling parts)
perform the convertfrom/convertto logic on their own... but the
commit message handling parts didn't.
They do now (git gui 0.6.5-11-gf20db5f).
Can you please test my current master branch and see if that fixes
things for you? repo.or.cz, git-gui.git...
If it does, I'm probably going to tag that as 0.6.6 and let Junio
cut 1.5.2 with that release.
--
Shawn.
next prev parent reply other threads:[~2007-04-24 6:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-23 11:32 [BUG] git gui and my ö Uwe Kleine-König
2007-04-24 5:39 ` Shawn O. Pearce
2007-04-24 6:16 ` Shawn O. Pearce [this message]
2007-04-24 8:57 ` Uwe Kleine-König
-- strict thread matches above, loose matches on Subject: below --
2007-04-25 22:48 Brett Schwarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070424061652.GP17480@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=ukleinek@informatik.uni-freiburg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.