From: Andrew Morton <akpm@linux-foundation.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: linux-kernel@vger.kernel.org, Paul Mundt <lethal@linux-sh.org>,
Ralf Baechle <ralf@linux-mips.org>, Andi Kleen <ak@suse.de>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Paul Mackerras <paulus@samba.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [patch v2] Fixes and cleanups for earlyprintk aka boot console.
Date: Tue, 24 Apr 2007 10:27:00 -0700 [thread overview]
Message-ID: <20070424102700.c58f8a6d.akpm@linux-foundation.org> (raw)
In-Reply-To: <462E0E60.5080907@redhat.com>
On Tue, 24 Apr 2007 16:04:16 +0200 Gerd Hoffmann <kraxel@redhat.com> wrote:
> > I get this, across netconsole:
> >
> > [17179569.184000] console handover: boot [earlyvga_f\x11_0] -> real [tty0]
> >
> > wanna take a look at why there's cruft in bootconsole->name please?
>
> -EFULL ;)
>
> "earlyvga" is 8 chars. struct console->name is char[8]. No space left
> for the trailing ´\0´, the cruft comes from the next field (write
> function pointer). Obviously nobody ever printed the early console
> names before.
doh.
> Hmm. We can make the names shorter. We can make the name field longer
> (probably 16, it ends up taking that much anyway due to aligments at
> least on 64bit). This looks best to me. We could also use
> printk("%.8s",name) to make printk stop after 8 chars, but I somehow
> don't like hardcoding the length like this ...
>
yup, making it 16 sounds simplest. I'll do the patch, thanks.
prev parent reply other threads:[~2007-04-24 17:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-15 15:46 [patch v2] Fixes and cleanups for earlyprintk aka boot console Gerd Hoffmann
2007-03-15 20:58 ` John Stoffel
2007-03-16 8:10 ` Gerd Hoffmann
2007-03-29 16:37 ` Olaf Dabrunz
2007-04-03 15:42 ` John Stoffel
2007-04-11 18:33 ` Olaf Dabrunz
2007-04-24 6:42 ` Andrew Morton
2007-04-24 14:04 ` Gerd Hoffmann
2007-04-24 17:27 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070424102700.c58f8a6d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@suse.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=benh@kernel.crashing.org \
--cc=ink@jurassic.park.msu.ru \
--cc=jeremy@goop.org \
--cc=kraxel@redhat.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.