All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: YOSHIFUJI Hideaki / ____________ <yoshfuji@linux-ipv6.org>,
	davem@davemloft.net, shemminger@osdl.org, netdev@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [net-2.6.22] [TCP]: Fix linkage errors.
Date: Tue, 24 Apr 2007 20:17:46 +0200	[thread overview]
Message-ID: <20070424181746.GP3468@stusta.de> (raw)
In-Reply-To: <20070424180348.2d40fbcb.dada1@cosmosbay.com>

On Tue, Apr 24, 2007 at 06:03:48PM +0200, Eric Dumazet wrote:
> On Tue, 24 Apr 2007 17:53:24 +0200
> Adrian Bunk <bunk@stusta.de> wrote:
> > Couldn't this be better solved by adding something like the following 
> > to include/linux/ktime.h ?
> > 
> > static inline s64 ktime_to_us(const ktime_t kt)
> > {
> >    return (s64) kt.tv.sec * USEC_PER_SEC + kt.tv.nsec / NSEC_PER_USEC;
> > }
> > 
> 
> Please check again include/linux/ktime.h
> 
> tv struct is defined inside 'ktime_t' only if BITS_PER_LONG != 64 && !defined(CONFIG_KTIME_SCALAR)

That's the difference between a "what about" suggestion and an actual 
patch...

I was merely suggesting solvin it through a ktime_to_us(), not 
presenting a complete and tested patch.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


      reply	other threads:[~2007-04-24 18:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-24 15:17 [net-2.6.22] [TCP]: Fix linkage errors YOSHIFUJI Hideaki / 吉藤英明
2007-04-24 15:53 ` Adrian Bunk
2007-04-24 15:58   ` YOSHIFUJI Hideaki / 吉藤英明
2007-04-24 16:10     ` YOSHIFUJI Hideaki / 吉藤英明
2007-04-24 16:38       ` Eric Dumazet
2007-04-24 17:04         ` [PATCH] Fix build errors on 32bit platforms with new ktime Stephen Hemminger
2007-04-24 18:19           ` Adrian Bunk
2007-04-24 18:48           ` Eric Dumazet
2007-04-24 21:54             ` David Miller
2007-04-24 21:55           ` YOSHIFUJI Hideaki / 吉藤英明
2007-04-24 21:57             ` Stephen Hemminger
2007-04-24 22:12               ` Eric Dumazet
2007-04-24 22:29                 ` Stephen Hemminger
2007-04-24 22:15               ` Thomas Gleixner
2007-04-24 22:49                 ` YOSHIFUJI Hideaki / 吉藤英明
2007-04-24 23:22                   ` David Miller
2007-04-24 16:03   ` [net-2.6.22] [TCP]: Fix linkage errors Eric Dumazet
2007-04-24 18:17     ` Adrian Bunk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070424181746.GP3468@stusta.de \
    --to=bunk@stusta.de \
    --cc=dada1@cosmosbay.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@osdl.org \
    --cc=tglx@linutronix.de \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.