All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aron Griffis <aron@hp.com>
To: "Daniel P. Berrange" <berrange@redhat.com>,
	xen-devel@lists.xensource.com
Subject: Re: PATCH: Remove execute permission from xend-debug.log
Date: Tue, 24 Apr 2007 17:45:24 -0400	[thread overview]
Message-ID: <20070424214524.GF2018@fc.hp.com> (raw)
In-Reply-To: <20070424213941.GE2018@fc.hp.com>

Aron Griffis wrote:  [Tue Apr 24 2007, 05:39:41PM EDT]
> Daniel P. Berrange wrote:  [Tue Apr 24 2007, 03:22:11PM EDT]
> > The file /var/log/xen/xend-debug.log is currently being created with 
> > executable permission bits set. This is because the os.open() method
> > defaults to using a mode of 0777 if no third parameter is provided.
> > The attached patch changes the mode to 0600 to ensure that the file
> > permissions come out as -rw-------  instead of -rwxr-xr-x
> 
> Doesn't os.open default to 0777 & ~umask?  Doesn't seem like xend
> should be overriding root's umask

Seems that the patch should be using 0666 instead of 0600 so that
umask can affect group/other perms.  At the very least it should use
0664.

Aron

  reply	other threads:[~2007-04-24 21:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-24 19:22 PATCH: Remove execute permission from xend-debug.log Daniel P. Berrange
2007-04-24 21:39 ` Aron Griffis
2007-04-24 21:45   ` Aron Griffis [this message]
2007-04-24 22:08     ` Keir Fraser
2007-04-24 22:15       ` Aron Griffis
2007-04-24 22:30         ` Keir Fraser
2007-04-24 22:35           ` Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070424214524.GF2018@fc.hp.com \
    --to=aron@hp.com \
    --cc=berrange@redhat.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.