From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aron Griffis Subject: Re: PATCH: Remove execute permission from xend-debug.log Date: Tue, 24 Apr 2007 17:45:24 -0400 Message-ID: <20070424214524.GF2018@fc.hp.com> References: <20070424192211.GJ30877@redhat.com> <20070424213941.GE2018@fc.hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20070424213941.GE2018@fc.hp.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Daniel P. Berrange" , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Aron Griffis wrote: [Tue Apr 24 2007, 05:39:41PM EDT] > Daniel P. Berrange wrote: [Tue Apr 24 2007, 03:22:11PM EDT] > > The file /var/log/xen/xend-debug.log is currently being created with > > executable permission bits set. This is because the os.open() method > > defaults to using a mode of 0777 if no third parameter is provided. > > The attached patch changes the mode to 0600 to ensure that the file > > permissions come out as -rw------- instead of -rwxr-xr-x > > Doesn't os.open default to 0777 & ~umask? Doesn't seem like xend > should be overriding root's umask Seems that the patch should be using 0666 instead of 0600 so that umask can affect group/other perms. At the very least it should use 0664. Aron