From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: Olof Johansson <olof@lixom.net>, paulus@samba.org
Subject: Re: [PATCH] pasemi: Kconfig for mdio_gpio
Date: Tue, 24 Apr 2007 23:53:06 +0200 [thread overview]
Message-ID: <200704242353.07286.arnd@arndb.de> (raw)
In-Reply-To: <20070424175834.GA7985@lixom.net>
On Tuesday 24 April 2007, Olof Johansson wrote:
> +config PPC_PASEMI_MDIO
> +=A0=A0=A0=A0=A0=A0=A0depends on PPC_PASEMI
> +=A0=A0=A0=A0=A0=A0=A0bool "MDIO support via GPIO"
> +=A0=A0=A0=A0=A0=A0=A0default y
> +=A0=A0=A0=A0=A0=A0=A0select PHYLIB
> +=A0=A0=A0=A0=A0=A0=A0help
> +=A0=A0=A0=A0=A0=A0=A0 =A0Driver for MDIO via GPIO on PWRficient platforms
> +
Looks still wrong. I stumbled over the original bug because in fedora,
CONFIG_PHYLIB=3Dm. When you make PPC_PASEMI_MDIO a bool, it will
force PHYLIB=3Dy, which is potentially undesired.
Can you make this a modular driver (tristate)?
Instead of making it select PHYLIB directly, it might be more
straightforward to make PPC_PASEMI_MDIO depend on PHYLIB
and have the actual network driver select both PPC_PASEMI_MDIO
and PHYLIB.
Arnd <><
next prev parent reply other threads:[~2007-04-24 21:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-24 17:58 [PATCH] pasemi: Kconfig for mdio_gpio Olof Johansson
2007-04-24 21:53 ` Arnd Bergmann [this message]
2007-04-24 23:04 ` Olof Johansson
2007-04-24 23:17 ` [PATCH v2] pasemi: Kconfig for gpio_mdio Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704242353.07286.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.