From: Len Brown <lenb@kernel.org>
To: Shaohua Li <shaohua.li@intel.com>
Cc: linux acpi <linux-acpi@vger.kernel.org>, Greg KH <greg@kroah.com>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Subject: Re: [PATCH] Disable MSI per FADT
Date: Wed, 25 Apr 2007 01:14:05 -0400 [thread overview]
Message-ID: <200704250114.06004.lenb@kernel.org> (raw)
In-Reply-To: <1177470312.11073.10.camel@sli10-conroe.sh.intel.com>
Applied.
thanks,
-Len
On Tuesday 24 April 2007 23:05, Shaohua Li wrote:
> ACPI spec defines the bit and Microsoft uses it. Suppose Linux should
> use it too.
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
>
> Index: 2.6.21-rc6/drivers/pci/pci-acpi.c
> ===================================================================
> --- 2.6.21-rc6.orig/drivers/pci/pci-acpi.c 2007-04-06 10:36:56.000000000 +0800
> +++ 2.6.21-rc6/drivers/pci/pci-acpi.c 2007-04-25 10:58:12.000000000 +0800
> @@ -317,6 +317,10 @@ static int __init acpi_pci_init(void)
> {
> int ret;
>
> + if (acpi_gbl_FADT.boot_flags & BAF_MSI_NOT_SUPPORTED) {
> + printk(KERN_INFO"ACPI FADT declares the system doesn't support MSI, so disable it\n");
> + pci_no_msi();
> + }
> ret = register_acpi_bus_type(&acpi_pci_bus);
> if (ret)
> return 0;
> Index: 2.6.21-rc6/include/acpi/actbl.h
> ===================================================================
> --- 2.6.21-rc6.orig/include/acpi/actbl.h 2007-04-06 10:36:56.000000000 +0800
> +++ 2.6.21-rc6/include/acpi/actbl.h 2007-04-25 10:22:28.000000000 +0800
> @@ -276,6 +276,7 @@ enum acpi_prefered_pm_profiles {
>
> #define BAF_LEGACY_DEVICES 0x0001
> #define BAF_8042_KEYBOARD_CONTROLLER 0x0002
> +#define BAF_MSI_NOT_SUPPORTED 0x0008
>
> #define FADT2_REVISION_ID 3
> #define FADT2_MINUS_REVISION_ID 2
>
next prev parent reply other threads:[~2007-04-25 5:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-25 3:05 [PATCH] Disable MSI per FADT Shaohua Li
2007-04-25 5:14 ` Len Brown [this message]
2007-04-25 15:01 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704250114.06004.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=greg@kroah.com \
--cc=hmh@hmh.eng.br \
--cc=linux-acpi@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.