From: Eric Sesterhenn / Snakebyte <snakebyte@gmx.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Jarek Poplawski <jarkao2@o2.pl>,
davem@davemloft.net, akpm@linux-foundation.org,
netdev@vger.kernel.org, bugme-daemon@bugzilla.kernel.org,
snakebyte@gmx.de
Subject: Re: [Bugme-new] [Bug 8057] New: slab corruption running ip6sic
Date: Wed, 25 Apr 2007 10:27:59 +0200 [thread overview]
Message-ID: <20070425082759.GA9258@alice> (raw)
In-Reply-To: <E1HgVf2-0001K7-00@gondolin.me.apana.org.au>
* Herbert Xu (herbert@gondor.apana.org.au) wrote:
> Jarek Poplawski <jarkao2@o2.pl> wrote:
> >
> > My proposal is: maybe Eric could change this in
> > xfrm6_tunnel_rcv() from xfrm6_tunnel.c e.g. like this:
> >
> > return xfrm6_rcv_spi(skb, spi) > 0 ? : 0;
> >
> > and, if no errors in testing, he could resubmit this patch?
>
> I agree, this is the right fix.
The fix proposed by Jarek indeed fixes the problem, tested on two boxes,
with an -rc5 kernel and a yesterdays git
Acked-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6/net/ipv6/xfrm6_tunnel.c.orig 2007-04-25 00:22:30.000000000 +0200
+++ linux-2.6/net/ipv6/xfrm6_tunnel.c 2007-04-25 00:22:45.000000000 +0200
@@ -261,7 +261,7 @@ static int xfrm6_tunnel_rcv(struct sk_bu
__be32 spi;
spi = xfrm6_tunnel_spi_lookup((xfrm_address_t *)&iph->saddr);
- return xfrm6_rcv_spi(skb, spi);
+ return xfrm6_rcv_spi(skb, spi) > 0 ? : 0;
}
static int xfrm6_tunnel_err(struct sk_buff *skb, struct inet6_skb_parm *opt,
next prev parent reply other threads:[~2007-04-25 8:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-22 21:49 Fw: [Bugme-new] [Bug 8057] New: slab corruption running ip6sic Andrew Morton
2007-03-12 10:24 ` Jarek Poplawski
2007-03-12 10:29 ` Jarek Poplawski
2007-04-20 23:35 ` David Miller
2007-04-23 6:44 ` Jarek Poplawski
2007-04-24 7:31 ` Jarek Poplawski
2007-04-25 0:47 ` Herbert Xu
2007-04-25 8:27 ` Eric Sesterhenn / Snakebyte [this message]
2007-04-25 12:05 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070425082759.GA9258@alice \
--to=snakebyte@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jarkao2@o2.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.