From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752225AbXDYTbA (ORCPT ); Wed, 25 Apr 2007 15:31:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752393AbXDYTbA (ORCPT ); Wed, 25 Apr 2007 15:31:00 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:44134 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751738AbXDYTa7 (ORCPT ); Wed, 25 Apr 2007 15:30:59 -0400 From: "Rafael J. Wysocki" To: Andrew Morton Subject: Re: [3/3] 2.6.21-rc7: known regressions (v2) Date: Wed, 25 Apr 2007 21:34:53 +0200 User-Agent: KMail/1.9.5 Cc: Adrian Bunk , Linus Torvalds , Linux Kernel Mailing List , Guilherme Schroeder , Thomas Gleixner , John Stultz , Ingo Molnar , Mikael Pettersson , ak@suse.de, discuss@x86-64.org, Jeff Chua , pavel@suse.cz, linux-pm@lists.linux-foundation.org, Dave Jones , "Eric W. Biederman" , "Antonino A. Daplas" , James Simmons , gregkh@suse.de, linux-pci@atrey.karlin.mff.cuni.cz, Tobias Diedrich , Dmitry Torokhov , Jeremy Fitzhardinge References: <20070423214909.GD3468@stusta.de> <20070425040605.6d6b4a82.akpm@linux-foundation.org> In-Reply-To: <20070425040605.6d6b4a82.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200704252134.55481.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, 25 April 2007 13:06, Andrew Morton wrote: > On Mon, 23 Apr 2007 23:49:09 +0200 Adrian Bunk wrote: > > > This email lists some known regressions in Linus' tree compared to 2.6.20. > > > > If you find your name in the Cc header, you are either submitter of one > > of the bugs, maintainer of an affectected subsystem or driver, a patch > > of you caused a breakage or I'm considering you in any other way > > possibly involved with one or more of these issues. > > > > Due to the huge amount of recipients, please trim the Cc when answering. > > > > > > Subject : HPET enabled freeze my machine at boot > > workaround: clocksource=acpi_pm > > References : http://lkml.org/lkml/2007/4/19/370 > > Submitter : Guilherme Schroeder > > Caused-By : Thomas Gleixner > > commit 5d8b34fdcb384161552d01ee8f34af5ff11f9684 > > Handled-By : John Stultz > > Status : problem is being debugged > > > > > > Subject : acpi_pm clocksource loses time on x86-64 > > References : http://lkml.org/lkml/2007/4/17/143 > > Submitter : Mikael Pettersson > > Handled-By : John Stultz > > Status : problem is being debugged > > > > > > Subject : suspend to disk hangs (CONFIG_NO_HZ) > > References : http://lkml.org/lkml/2007/3/25/217 > > Submitter : Jeff Chua > > Status : unknown > > That's still rather a lot of bustage from the timekeeping changes. Is > anything really happening here or have we all given up? > > > > > Subject : ThinkPad X60: resume no longer works (PCI related?) > > workaround: CONFIG_FB_BACKLIGHT=n > > References : http://lkml.org/lkml/2007/3/13/3 > > Submitter : Dave Jones > > Caused-By : PCI merge > > commit 78149df6d565c36675463352d0bfe0000b02b7a7 > > Handled-By : Eric W. Biederman > > Rafael J. Wysocki > > Antonino A. Daplas > > Status : unknown > > > > Is this related to the problems Jeremy has been looking at? > > > Subject : suspend to disk works only once > > workaround: "echo shutdown > /sys/power/disk" > > References : http://lkml.org/lkml/2007/4/13/240 > > Submitter : Tobias Diedrich > > Caused-By : Rafael J. Wysocki > > commit ed746e3b18f4df18afa3763155972c5835f284c5 > > Handled-By : Rafael J. Wysocki > > Dmitry Torokhov > > Status : problem is being debugged > > That's been happening on my Vaio-of-death for several weeks now. I spent a > bit of time with the ACPI guys on it but we didn't get far. I need to > find an hour or two to work out what's gone wrong. I can't reproduce it on any of my machines ... Does the appended patch help, BTW? --- kernel/power/disk.c | 4 ++-- kernel/power/user.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) Index: linux-2.6.21-rc7/kernel/power/disk.c =================================================================== --- linux-2.6.21-rc7.orig/kernel/power/disk.c +++ linux-2.6.21-rc7/kernel/power/disk.c @@ -170,9 +170,9 @@ int pm_suspend_disk(void) if (in_suspend) { enable_nonboot_cpus(); - platform_finish(); device_resume(); resume_console(); + platform_finish(); pr_debug("PM: writing image.\n"); error = swsusp_write(); if (!error) @@ -189,9 +189,9 @@ int pm_suspend_disk(void) Enable_cpus: enable_nonboot_cpus(); Resume_devices: - platform_finish(); device_resume(); resume_console(); + platform_finish(); Thaw: unprepare_processes(); Finish: Index: linux-2.6.21-rc7/kernel/power/user.c =================================================================== --- linux-2.6.21-rc7.orig/kernel/power/user.c +++ linux-2.6.21-rc7/kernel/power/user.c @@ -170,11 +170,11 @@ static inline int snapshot_suspend(int p } enable_nonboot_cpus(); Resume_devices: + device_resume(); + resume_console(); if (platform_suspend) platform_finish(); - device_resume(); - resume_console(); Finish: mutex_unlock(&pm_mutex); return error; @@ -202,11 +202,11 @@ static inline int snapshot_restore(int p enable_nonboot_cpus(); Resume_devices: + device_resume(); + resume_console(); if (platform_suspend) platform_finish(); - device_resume(); - resume_console(); Finish: pm_restore_console(); mutex_unlock(&pm_mutex);