All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@mvista.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [RFC/PATCH] ARM: OMAP: OneNAND support for 2430SDP
Date: Thu, 26 Apr 2007 17:35:08 +0000	[thread overview]
Message-ID: <20070426173507.GB9764@atomide.com> (raw)
In-Reply-To: <20070321004030.424076000@mvista.com>

* Kevin Hilman <khilman@mvista.com> [070321 00:49]:
> Adds platform device for use of existing OMAP2 driver.  Also, the
> following changes are made to the existing driver:
> 
> - add option for not using DMA (by passing dma_channel = -1)
> - removes obsoleted pt_regs arg from interrupt handler
> 
> RFC: Notice the change to onenand_base.c which comments out the last
>      OOB chunk.  Without this, it would not work.  Previous drivers
>      for this board such as the 2.6.10-based MV kernel have this
>      same change.  Anyone know what is going on here?

Can you please refresh this one and split it into two patches:

>  arch/arm/mach-omap2/Makefile              |    3 
>  arch/arm/mach-omap2/board-2430sdp-flash.c |  108 ++++++++++++++++++++++++++++++
>  arch/arm/mach-omap2/board-2430sdp.c       |    4 +
>  arch/arm/mach-omap2/gpmc.c                |    1 
>  include/asm-arm/arch-omap/gpmc.h          |    7 +
>  include/asm-arm/arch-omap/onenand.h       |    1 

The above could be one patch ready for omap-upstream queue.

>  drivers/mtd/onenand/omap2.c               |  103 +++++++++++++++++-----------
>  drivers/mtd/onenand/onenand_base.c        |    2 

This should be separate and sent to MTD list.

Regards,

Tony

  parent reply	other threads:[~2007-04-26 17:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-21  0:40 [RFC/PATCH] ARM: OMAP: OneNAND support for 2430SDP Kevin Hilman
2007-03-21 19:15 ` Jalori, Mohit
2007-03-21 19:50   ` Kevin Hilman
2007-03-22  1:06     ` Kyungmin Park
2007-03-22  3:14       ` Kevin Hilman
2007-03-22  4:50         ` Kyungmin Park
2007-03-22  5:02           ` Kyungmin Park
2007-03-22 16:53             ` Kevin Hilman
2007-03-23  4:40               ` Kyungmin Park
2007-04-26 17:35 ` Tony Lindgren [this message]
2007-04-30 22:34   ` Kevin Hilman
2007-05-02 17:45     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070426173507.GB9764@atomide.com \
    --to=tony@atomide.com \
    --cc=khilman@mvista.com \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.