From mboxrd@z Thu Jan 1 00:00:00 1970 From: olof@lixom.net (Olof Johansson) Subject: Re: [PATCH v2] [2.6.22] pasemi: cpufreq driver Date: Thu, 26 Apr 2007 15:38:02 -0500 Message-ID: <20070426203802.GC17302@lixom.net> References: <20070425204633.GC19781@lixom.net> <200704261055.33739.arnd@arndb.de> <20070426164835.GA14149@lixom.net> <200704261911.22553.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org To: Segher Boessenkool Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, egor@pasemi.com, Arnd Bergmann , cpufreq@lists.linux.org.uk On Thu, Apr 26, 2007 at 09:05:59PM +0200, Segher Boessenkool wrote: > >>Unfortunately the setting of the current active state is done to an > >>SDC > >>register, while information of the states is in the PMU, so access to > >>both is needed in the driver. > > > >One thing that you could do is to list only this one register of the > >SDC in the reg property, not all of the SDC. > > The system-controller node should really describe > all of the system controller. If the Linux driver > needs to access two separate devices, it should > really just do that. Don't try to make things > "simpler" in the device tree. > > You probably should map the SDC registers in the > platform startop code, and then have the various > platform drivers use that. Maybe even do an > abstraction ;-) Yep, it's a good idea to do and I'll look at it for 2.6.23 time frame. Thanks, -Olof