From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: PATCH: Don't use -q flag to bootloader if activating text console Date: Thu, 26 Apr 2007 21:57:13 +0100 Message-ID: <20070426205713.GI14188@redhat.com> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="HcAYCG3uE/tztfnV" Return-path: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org --HcAYCG3uE/tztfnV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In Xen 3.0.3 series release, if one did 'xm create -c someguest' then you would be shown the pygrub boot menu, allowing one to pick a kernel. If you didn't use the -c arg, then it'd just pick the default kernel. In Xen 3.0.5 testing, xm is forcing the addition of the '-q' flag whenever the 'bootargs' parameter is not given in the config file. So if one does not have 'bootargs' specified, and one uses 'xm create -c someguest' you never get to see the pygrub boot menu. The attached patch fixes 'xm create' so that it does not add the '-q' flag to the bootloader args, if the '-c' flag is given to xm create. This makes the default user experiance operate closer to user expectations Signed-off-by: Daniel P. Berrange Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=| --HcAYCG3uE/tztfnV Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="xen-bootloader-display.patch" diff -r ee16cdeddade tools/python/xen/xm/create.py --- a/tools/python/xen/xm/create.py Wed Apr 25 10:39:08 2007 +0100 +++ b/tools/python/xen/xm/create.py Thu Apr 26 17:10:50 2007 -0400 @@ -777,8 +777,11 @@ def make_config(vals): config.append(['bootloader', vals.bootloader]) if vals.bootargs: config.append(['bootloader_args', vals.bootargs]) - else: - config.append(['bootloader_args', '-q']) + else: + if vals.console_autoconnect: + config.append(['bootloader_args', '']) + else: + config.append(['bootloader_args', '-q']) config.append(['image', config_image]) config_devs = [] --HcAYCG3uE/tztfnV Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --HcAYCG3uE/tztfnV--