All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: ego@in.ibm.com, Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>, Oleg Nesterov <oleg@tv-sign.ru>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -mm 2/2] Introduce freezer flags
Date: Sat, 28 Apr 2007 00:07:10 +0200	[thread overview]
Message-ID: <20070427220710.GC2994@elf.ucw.cz> (raw)
In-Reply-To: <200704280009.19639.rjw@sisk.pl>

Hi!

> > > > +#ifdef CONFIG_FREEZER
> > > > +	/* Used by the process freezer, defined in freezer.h */
> > > > +	unsigned int freezer_flags;
> > > 
> > > unsigned long freezer_flags; ??
> > 
> > I guess so.
> 
> Still, on x86_64, for example, we'll waste 4 bytes by using 'unsigned long'
> here, which I wouldn't like to do.
> 
> Is it acceptable to use explicit type casting in set_bit() and friends?

I'm afraid set_bit & friends are only defined on unsigned long. You
can cast, but you may run into some nasty surprise... like damaging
surrounding bytes on 64-bit architectures != x86_64.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2007-04-27 22:08 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-27 15:37 [PATCH -mm 0/2] Separate freezer from PM code Rafael J. Wysocki
2007-04-27 15:38 ` [PATCH -mm 1/2] " Rafael J. Wysocki
2007-04-27 16:15   ` Sam Ravnborg
2007-04-27 16:25   ` Jeremy Fitzhardinge
2007-04-27 20:20     ` Rafael J. Wysocki
2007-04-27 20:20       ` Jeremy Fitzhardinge
2007-04-27 21:29         ` Rafael J. Wysocki
2007-04-29  8:43           ` Sam Ravnborg
2007-04-27 15:40 ` [PATCH -mm 2/2] Introduce freezer flags Rafael J. Wysocki
2007-04-27 16:19   ` Sam Ravnborg
2007-04-27 16:33     ` Gautham R Shenoy
2007-04-27 21:40   ` Gautham R Shenoy
2007-04-27 21:49     ` Rafael J. Wysocki
2007-04-27 21:49       ` Gautham R Shenoy
2007-04-27 22:09       ` Rafael J. Wysocki
2007-04-27 22:07         ` Pavel Machek [this message]
2007-04-27 22:56           ` Rafael J. Wysocki
2007-04-28  7:07             ` Pavel Machek
2007-04-28  1:34   ` [PATCH -mm] Allow selective freezing of the system for different events Gautham R Shenoy
2007-04-28  6:22     ` Andrew Morton
2007-04-28  7:45       ` Gautham R Shenoy
2007-04-29 17:51     ` Rafael J. Wysocki
2007-04-30 19:19       ` Gautham R Shenoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070427220710.GC2994@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=akpm@linux-foundation.org \
    --cc=ego@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@tv-sign.ru \
    --cc=penberg@cs.helsinki.fi \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.