From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1HiIop-0008RK-Or for mharc-grub-devel@gnu.org; Sun, 29 Apr 2007 19:28:39 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HiIoo-0008RF-NO for grub-devel@gnu.org; Sun, 29 Apr 2007 19:28:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HiIon-0008R3-48 for grub-devel@gnu.org; Sun, 29 Apr 2007 19:28:37 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HiIom-0008R0-TA for grub-devel@gnu.org; Sun, 29 Apr 2007 19:28:36 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HiIid-0005Jr-R5 for grub-devel@gnu.org; Sun, 29 Apr 2007 19:22:17 -0400 Received: from [192.168.10.6] (helo=aragorn) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1HiIiU-0001lz-Kf for grub-devel@gnu.org; Mon, 30 Apr 2007 01:22:08 +0200 Received: from rmh by aragorn with local (Exim 4.63) (envelope-from ) id 1HiIjD-0000kM-5j for grub-devel@gnu.org; Mon, 30 Apr 2007 01:22:51 +0200 Date: Mon, 30 Apr 2007 01:22:51 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20070429232251.GA2611@aragorn> References: <20061015101842.GC4265@khazad.dyndns.org> <20070411155040.GA6722@aragorn> <20070417124954.GA28437@aragorn> <200704211538.38367.okuji@enbug.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="82I3+IH0IqGh5yIs" Content-Disposition: inline In-Reply-To: <200704211538.38367.okuji@enbug.org> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: Genre and OS details not recognized. Subject: Re: update-grub2 patch X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2007 23:28:38 -0000 --82I3+IH0IqGh5yIs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Apr 21, 2007 at 03:38:38PM +0200, Yoshinori K. Okuji wrote: > On Tuesday 17 April 2007 14:49, Robert Millan wrote: > > Here's my patch. Let me know if it's ok for commit. > > To include this in the official repository, you need to take care about the > portability. [...] I ported it to bourne shell. It's tested and known to work with dash as /bin/sh. I think this should address your concern. My new patch also arranges the logic for generating update-grub components to make it more similar to how grub-install is handled. -- Robert Millan My spam trap is honeypot@aybabtu.com. Note: this address is only intended for spam harvesters. Writing to it will get you added to my black list. --82I3+IH0IqGh5yIs Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="update-grub2.diff" 2007-04-30 Robert Millan * DISTLIST: Add util/update-grub.in, util/grub.d/00_header.in, util/grub.d/10_hurd.in, util/grub.d/10_linux.in and util/grub.d/README. * Makefile.in: Build update-grub_SCRIPTS. Install update-grub_SCRIPTS and update-grub_DATA. * conf/common.rmk: Build and install update-grub components. * conf/common.mk: Regenerate. * util/update-grub.in: New. Core of update-grub. * util/grub.d/00_header.in: New. Generates grub.cfg header. * util/grub.d/10_hurd.in: New. Generates boot entries for the Hurd. * util/grub.d/10_linux.in: New. Generates boot entries for Linux. * util/grub.d/README: New. Document grub.d directory layout. Index: DISTLIST =================================================================== RCS file: /sources/grub/grub2/DISTLIST,v retrieving revision 1.38 diff -u -r1.38 DISTLIST --- DISTLIST 14 Oct 2006 18:59:34 -0000 1.38 +++ DISTLIST 29 Apr 2007 23:00:30 -0000 @@ -258,6 +258,11 @@ util/raid.c util/resolve.c util/unifont2pff.rb +util/update-grub.in +util/grub.d/00_header.in +util/grub.d/10_hurd.in +util/grub.d/10_linux.in +util/grub.d/README util/i386/efi/grub-mkimage.c util/i386/pc/biosdisk.c util/i386/pc/getroot.c Index: Makefile.in =================================================================== RCS file: /sources/grub/grub2/Makefile.in,v retrieving revision 1.24 diff -u -r1.24 Makefile.in --- Makefile.in 10 Apr 2007 21:38:26 -0000 1.24 +++ Makefile.in 29 Apr 2007 23:00:30 -0000 @@ -87,7 +87,7 @@ DATA = $(pkgdata_IMAGES) $(pkgdata_MODULES) $(pkgdata_PROGRAMS) \ $(pkgdata_DATA) PROGRAMS = $(bin_UTILITIES) $(sbin_UTILITIES) -SCRIPTS = $(sbin_SCRIPTS) +SCRIPTS = $(sbin_SCRIPTS) $(update-grub_SCRIPTS) CLEANFILES = MOSTLYCLEANFILES = @@ -153,6 +153,17 @@ dest="`echo $$file | sed 's,.*/,,' | sed '$(transform)'`"; \ $(INSTALL_SCRIPT) $$dir$$file $(DESTDIR)$(sbindir)/$$dest; \ done + $(mkinstalldirs) $(DESTDIR)$(sysconfdir)/grub.d + @list='$(update-grub_SCRIPTS)'; for file in $$list; do \ + if test -f "$$file"; then dir=; else dir="$(srcdir)"; fi; \ + dest="`echo $$file | sed 's,.*/,,' | sed '$(transform)'`"; \ + $(INSTALL_SCRIPT) $$dir$$file $(DESTDIR)$(sysconfdir)/grub.d/$$dest; \ + done + @list='$(update-grub_DATA)'; for file in $$list; do \ + if test -f "$$file"; then dir=; else dir="$(srcdir)"; fi; \ + dest="`echo $$file | sed 's,.*/,,' | sed '$(transform)'`"; \ + $(INSTALL_DATA) $$dir$$file $(DESTDIR)$(sysconfdir)/grub.d/$$dest; \ + done install-strip: $(MAKE) INSTALL_PROGRAM="$(INSTALL_STRIP_PROGRAM)" install Index: conf/common.rmk =================================================================== RCS file: /sources/grub/grub2/conf/common.rmk,v retrieving revision 1.12 diff -u -r1.12 common.rmk --- conf/common.rmk 3 Nov 2006 20:28:04 -0000 1.12 +++ conf/common.rmk 29 Apr 2007 23:00:32 -0000 @@ -18,6 +18,33 @@ rm -f $@; sh $(srcdir)/geninit.sh $(filter %.c,$^) > $@ DISTCLEANFILES += grub_emu_init.c +# For update-grub +update-grub: util/update-grub.in config.status + ./config.status --file=$@:$< + chmod +x $@ +sbin_SCRIPTS += update-grub +CLEANFILES += update-grub + +00_header: util/grub.d/00_header.in config.status + ./config.status --file=$@:$< + chmod +x $@ +update-grub_SCRIPTS += 00_header +CLEANFILES += 00_header + +10_linux: util/grub.d/10_linux.in config.status + ./config.status --file=$@:$< + chmod +x $@ +update-grub_SCRIPTS += 10_linux +CLEANFILES += 10_linux + +10_hurd: util/grub.d/10_hurd.in config.status + ./config.status --file=$@:$< + chmod +x $@ +update-grub_SCRIPTS += 10_hurd +CLEANFILES += 10_hurd + +update-grub_DATA += util/grub.d/README + # Filing systems. pkgdata_MODULES += fshelp.mod fat.mod ufs.mod ext2.mod \ Index: util/update-grub.in =================================================================== RCS file: util/update-grub.in diff -N util/update-grub.in --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ util/update-grub.in 29 Apr 2007 23:00:32 -0000 @@ -0,0 +1,94 @@ +#! /bin/sh -e + +# Generate grub.cfg by inspecting /boot contents. +# Copyright (C) 2006, 2007 Free Software Foundation, Inc. +# +# This file is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, but +# WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +# General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin St - Suite 330, Boston, MA 02110, USA. + +transform="@program_transform_name@" + +sysconfdir=@sysconfdir@ +grub_prefix=`echo /boot/grub | sed ${transform}` +grub_cfg=${grub_prefix}/grub.cfg +update_grub_dir=${sysconfdir}/grub.d +test_mode=false + +if test -z "$UID" ; then + UID=`id -u` +fi + +if [ "$UID" != 0 ] ; then + echo "$0: You must run this as root" >&2 + exit 1 +fi + +if [ "$1" = "-y" ] ; then + echo "$0: warning: Ignoring -y option (no longer needed)." >&2 +fi + +if test ! -d ${update_grub_dir} && test -d ./grub.d ; then + update_grub_dir=./grub.d + test_mode=true +fi + +if which grub-probe > /dev/null ; then : ; else + echo "$0: grub-probe not found in PATH." >&2 + exit 1 +fi + +if ${test_mode} ; then : ; else + exec > ${grub_cfg}.new + chmod 444 ${grub_cfg}.new +fi + +if test -f ${sysconfdir}/default/grub ; then + . ${sysconfdir}/default/grub +fi + +echo "Updating ${grub_cfg} ..." >&2 + +cat << EOF +# +# DO NOT EDIT THIS FILE +# +# It is automaticaly generated by $0 using templates from ${update_grub_dir} +# +EOF + +export GRUB_DEVICE="`grub-probe --target=device ${grub_prefix}`" +export GRUB_DRIVE="`grub-probe --target=drive ${grub_prefix}`" +export GRUB_FS="`grub-probe --target=fs ${grub_prefix}`" + +for i in ${update_grub_dir}/* ; do + case $i in + # emacsen backup files. FIXME: support other editors + *~) ;; + *) + if test -x $i ; then + echo + echo "### BEGIN $i ###" + $i + echo "### END $i ###" + fi + ;; + esac +done + +# none of the children aborted with error, install the new grub.cfg +if ${test_mode} ; then : ; else + mv ${grub_cfg}.new ${grub_cfg} +fi + +echo "done" >&2 Index: util/grub.d/00_header.in =================================================================== RCS file: util/grub.d/00_header.in diff -N util/grub.d/00_header.in --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ util/grub.d/00_header.in 29 Apr 2007 23:00:32 -0000 @@ -0,0 +1,28 @@ +#! /bin/sh -e + +# update-grub helper script. +# Copyright (C) 2006 Free Software Foundation, Inc. +# +# This file is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, but +# WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +# General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin St - Suite 330, Boston, MA 02110, USA. + + +if [ -z "${GRUB_DEFAULT}" ] ; then GRUB_DEFAULT=0 ; fi +if [ -z "${GRUB_TIMEOUT}" ] ; then GRUB_TIMEOUT=5 ; fi + +cat << EOF +set default=${GRUB_DEFAULT} +set timeout=${GRUB_TIMEOUT} +set root=${GRUB_DRIVE} +EOF Index: util/grub.d/10_hurd.in =================================================================== RCS file: util/grub.d/10_hurd.in diff -N util/grub.d/10_hurd.in --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ util/grub.d/10_hurd.in 29 Apr 2007 23:00:32 -0000 @@ -0,0 +1,72 @@ +#! /bin/sh -e + +# update-grub helper script. +# Copyright (C) 2006, 2007 Free Software Foundation, Inc. +# +# This file is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, but +# WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +# General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin St - Suite 330, Boston, MA 02110, USA. + +if test -z "${GRUB_DISTRIBUTOR}" ; then + OS=GNU +else + OS="${GRUB_DISTRIBUTOR} GNU/Hurd" +fi + +# FIXME: add l4 here? +kernel= +for i in /boot/gnumach.gz /boot/gnumach ; do + if test -e $i ; then + kernel=$i + fi +done + +# FIXME: This works for ext2. For other filesystems we might need special-casing +case "${GRUB_FS}" in + *fs) hurd_fs="${GRUB_FS}" ;; + *) hurd_fs="${GRUB_FS}fs" ;; +esac + +at_least_one=false +all_of_them=true +for i in "${kernel}" /hurd/${hurd_fs}.static /hurd/exec ; do + if test -e "$i" ; then + echo "Found Hurd module: $i" >&2 + at_least_one=true + else + all_of_them=false + fi +done + +if ${at_least_one} ; then : ; else + # no hurd here, aborting silently + exit 0 +fi + +if ${all_of_them} && test -e /lib/ld.so.1 ; then : ; else + echo "Some Hurd stuff found, but not enough to boot." >&2 + exit 1 +fi + +cat << EOF +menuentry "${OS}" { + multiboot ${kernel} root=device:${GRUB_DEVICE} + module /hurd/${hurd_fs}.static --readonly \\ + --multiboot-command-line='\${kernel-command-line}' \\ + --host-priv-port='\${host-port}' \\ + --device-master-port='\${device-port}' \\ + --exec-server-task='\${exec-task}' -T typed '\${root}' \\ + '\$(task-create)' '\$(task-resume)' + module /lib/ld.so.1 /hurd/exec '\$(exec-task=task-create)' +} +EOF Index: util/grub.d/10_linux.in =================================================================== RCS file: util/grub.d/10_linux.in diff -N util/grub.d/10_linux.in --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ util/grub.d/10_linux.in 29 Apr 2007 23:00:32 -0000 @@ -0,0 +1,54 @@ +#! /bin/sh -e + +# update-grub helper script. +# Copyright (C) 2006, 2007 Free Software Foundation, Inc. +# +# This file is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, but +# WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +# General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin St - Suite 330, Boston, MA 02110, USA. + +if [ -n "${GRUB_DISTRIBUTOR}" ] ; then GRUB_DISTRIBUTOR="${GRUB_DISTRIBUTOR} " ; fi + +for linux in /boot/vmlinu[xz]-* /vmlinu[xz]-* ; do + if test -e ${linux} ; then : ; else + continue + fi + echo "Found linux image: $linux" >&2 + version=`echo $linux | sed -e "s,.*/[^0-9]*-,,g"` + basedir=`echo $linux | sed -e "s,/[^/]*$,,g"` + cat << EOF +menuentry "${GRUB_DISTRIBUTOR}GNU/Linux, linux ${version}" { + linux ${linux} root=${GRUB_DEVICE} ro +EOF + if test -e ${basedir}/initrd.img-${version} ; then + echo "Found initrd image: ${basedir}/initrd.img-${version}" >&2 + cat << EOF + initrd ${basedir}/initrd.img-${version} +EOF + fi + cat << EOF +} +EOF + cat << EOF +menuentry "${GRUB_DISTRIBUTOR}GNU/Linux, linux ${version} (single-user mode)" { + linux ${linux} root=${GRUB_DEVICE} ro single +EOF + if test -e ${basedir}/initrd.img-${version} ; then + cat << EOF + initrd ${basedir}/initrd.img-${version} +EOF + fi + cat << EOF +} +EOF +done Index: util/grub.d/README =================================================================== RCS file: util/grub.d/README diff -N util/grub.d/README --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ util/grub.d/README 29 Apr 2007 23:00:32 -0000 @@ -0,0 +1,11 @@ + +All executable files in this directory are processed in shell expansion order. + + 00_*: Reserved for 00_header. + 10_*: Native boot entries. + 20_*: Third party apps (e.g. memtest86+). + +The number namespace in-between is configurable by system installer and/or +administrator. For example, you can add an entry to boot another OS as +01_otheros, 11_otheros, etc, depending on the position you want it to occupy in +the menu; and then adjust the default setting via /etc/default/grub. --82I3+IH0IqGh5yIs--