All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@ozlabs.org
Subject: Re: powerpc: Remove arch/powerpc's dependence on asm-ppc/pg{alloc, table}.h
Date: Mon, 30 Apr 2007 11:18:46 +0200	[thread overview]
Message-ID: <20070430091846.GA15581@lst.de> (raw)
In-Reply-To: <20070430063056.GB4683@localhost.localdomain>

On Mon, Apr 30, 2007 at 04:30:56PM +1000, David Gibson wrote:
> powerpc: Remove arch/powerpc's dependence on asm-ppc/pg{alloc,table}.h
> 
> Currently, all 32-bit powerpc platforms use asm-ppc/pgtable.h and
> asm-ppc/pgalloc.h, even when otherwise compiled with ARCH=powerpc.
> Those asm-ppc files are a fairly nasty tangle of #ifdefs including a
> bunch of things which shouldn't be necessary any more in arch/powerpc.
> 
> Cleaning up that mess is going to take a while, but this patch is a
> first step.  It separates the asm-powerpc/pg{alloc,table}.h into 64
> bit and 32 bit versions in asm-powerpc, which the basic .h files in
> asm-powerpc select based on config.  We make a few tiny tweaks to the
> innards of the files along the way, making the outermost ifdefs
> (double-inclusion protection and __KERNEL__) a little cleaner, and
> #including asm-generic/pgtable.h from the top-level
> asm-powerpc/pgtable.h (since both the old 32-bit and 64-bit versions
> ended with such an #include).

Nice cleanup.  Btw, you can just kill the __KERNEL__ completely,
neither pgalloc.h nor pgtable are exported to userspace (as in
part of header-y or unifdef-y in include/asm-powerpc/Kbuild)

  reply	other threads:[~2007-04-30  9:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-30  5:37 powerpc: Remove arch/powerpc's dependence on asm-ppc/pg{alloc, table}.h David Gibson
2007-04-30  6:30 ` David Gibson
2007-04-30  9:18   ` Christoph Hellwig [this message]
2007-04-30 11:30     ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070430091846.GA15581@lst.de \
    --to=hch@lst.de \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.