From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@vger.kernel.org, stable@kernel.org,
Francois SIMOND <curio@free.fr>
Subject: [PATCH] sky2: re-enable 88E8056 for most motherboards
Date: Mon, 30 Apr 2007 14:23:49 -0700 [thread overview]
Message-ID: <20070430142349.79754c1b@freekitty> (raw)
This fixes the regression in 2.6.21 for users with 88e8056 on motherboard.
Allow all but the Gigabyte motherboard has some unresolved bus problems.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
---
drivers/net/sky2.c | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
--- sky2-2.6.21.orig/drivers/net/sky2.c 2007-04-27 13:37:32.000000000 -0700
+++ sky2-2.6.21/drivers/net/sky2.c 2007-04-30 14:01:15.000000000 -0700
@@ -123,10 +123,7 @@ static const struct pci_device_id sky2_i
{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4361) }, /* 88E8050 */
{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4362) }, /* 88E8053 */
{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4363) }, /* 88E8055 */
-#ifdef broken
- /* This device causes data corruption problems that are not resolved */
{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4364) }, /* 88E8056 */
-#endif
{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4366) }, /* 88EC036 */
{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4367) }, /* 88EC032 */
{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4368) }, /* 88EC034 */
@@ -3580,10 +3577,21 @@ static int __devinit sky2_probe(struct p
goto err_out;
}
+ /* Some Gigabyte motherboards have 88e8056 but cause problems
+ * There is some unresolved hardware related problem that causes
+ * descriptor errors and receive data corruption.
+ */
+ if (pdev->vendor == PCI_VENDOR_ID_MARVELL &&
+ pdev->device == 0x4364 && pdev->subsystem_vendor == 0x1458) {
+ dev_err(&pdev->dev,
+ "88E8056 on Gigabyte motherboards not supported\n");
+ goto err_out_disable;
+ }
+
err = pci_request_regions(pdev, DRV_NAME);
if (err) {
dev_err(&pdev->dev, "cannot obtain PCI resources\n");
- goto err_out;
+ goto err_out_disable;
}
pci_set_master(pdev);
@@ -3720,6 +3728,7 @@ err_out_free_hw:
kfree(hw);
err_out_free_regions:
pci_release_regions(pdev);
+err_out_disable:
pci_disable_device(pdev);
err_out:
return err;
next reply other threads:[~2007-04-30 21:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-30 21:23 Stephen Hemminger [this message]
2007-05-01 13:58 ` [PATCH] sky2: re-enable 88E8056 for most motherboards Daniel Drake
2007-05-02 22:42 ` Stephen Hemminger
2007-05-03 19:23 ` Daniel Drake
2007-05-10 16:00 ` Stephen Hemminger
2007-05-13 15:55 ` Daniel Drake
2007-05-14 19:02 ` Stephen Hemminger
2007-05-17 2:09 ` Daniel Drake
2007-05-17 2:58 ` Jeff Garzik
2007-05-17 3:21 ` Daniel Drake
2007-05-08 5:23 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2007-05-14 1:27 kernel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070430142349.79754c1b@freekitty \
--to=shemminger@linux-foundation.org \
--cc=curio@free.fr \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.