From: Frank Pavlic <fpavlic@de.ibm.com>
To: hch@infradead.org, jgarzik@pobox.com
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH 3/5] s390: use kthread_run in qeth and lcs
Date: Mon, 30 Apr 2007 18:30:04 +0200 [thread overview]
Message-ID: <20070430163004.GA17951@de.ibm.com> (raw)
In-Reply-To: <20070430160329.GB27438@infradead.org>
On Mon, Apr 30, 2007 at 05:03:29PM +0100, Christoph Hellwig wrote:
> On Mon, Apr 30, 2007 at 05:42:57PM +0200, Frank Pavlic wrote:
> > From: Eric Biederman <ebiederm@xmission.com>
> >
> > This patch modifies the qeth_recover thread to be started
> > with kthread_run not a combination of kernel_thread and
> > daemonize. Resulting in slightly simpler and more maintainable
> > code.
>
> NACK, this is Eric's partial conversion which doesn't help much
> at all. In fact it might actually hurt by introducing unpaired
> kthread calls.
Alright Christoph, thanks for clarifying this..
@Jeff,
I'll send you another set without this one...
Frank
prev parent reply other threads:[~2007-04-30 16:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-30 15:42 [PATCH 3/5] s390: use kthread_run in qeth and lcs Frank Pavlic
2007-04-30 16:03 ` Christoph Hellwig
2007-04-30 16:30 ` Frank Pavlic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070430163004.GA17951@de.ibm.com \
--to=fpavlic@de.ibm.com \
--cc=hch@infradead.org \
--cc=jgarzik@pobox.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.