From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946729AbXD3TgH (ORCPT ); Mon, 30 Apr 2007 15:36:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1946662AbXD3TgG (ORCPT ); Mon, 30 Apr 2007 15:36:06 -0400 Received: from mx1.redhat.com ([66.187.233.31]:35642 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946729AbXD3TgF (ORCPT ); Mon, 30 Apr 2007 15:36:05 -0400 Date: Mon, 30 Apr 2007 15:35:53 -0400 From: Dave Jones To: David Rientjes Cc: linux-kernel@vger.kernel.org Subject: Re: [patch] cpufreq: do not declare undefined functions Message-ID: <20070430193553.GF9385@redhat.com> Mail-Followup-To: Dave Jones , David Rientjes , linux-kernel@vger.kernel.org References: <20070430155917.GB18187@redhat.com> <20070430185216.GC9385@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 30, 2007 at 12:10:45PM -0700, David Rientjes wrote: > On Mon, 30 Apr 2007, Dave Jones wrote: > > > > > it's just a prototype, so no code is generated by declaring one > > > > to an unused (or even non-existant) function. > > > > > > > > Or are you using some oddball compiler that warns about this? > > > > > > > > > > If you consider gcc to be oddball, yes. > > > > what version ? Mine doesn't seem to warn on that. > > > 4.1.2 > > arch/i386/kernel/cpu/cpufreq/powernow-k8.h:218: warning: 'fill_powernow_table_pstate' declared 'static' but never defined > arch/i386/kernel/cpu/cpufreq/powernow-k8.h:219: warning: 'fill_powernow_table_fidvid' declared 'static' but never defined > > Make sure CONFIG_X86_POWERNOW_K8=y and CONFIG_X86_POWERNOW_K8_ACPI=n. Ah, I had ACPI_PROCESSOR=y, which was flipping it back on after I'd changed it. Ok. Thanks. Dave -- http://www.codemonkey.org.uk