From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Bill Irwin <bill.irwin@oracle.com>,
linux-kernel@vger.kernel.org, bunk@stusta.de, akpm@osdl.org,
gcoady@gmail.com, zlynx@acm.org, dgc@sgi.com,
alan@lxorguk.ukuu.org.uk, andi@firstfloor.org, hch@infradead.org,
jengelh@linux01.gwdg.de, zwane@infradead.org, neilb@suse.de,
jens.axboe@oracle.com, eric@provenscaling.com
Subject: Re: [1/3] dynamically allocate IRQ stacks
Date: Tue, 1 May 2007 19:04:26 +0200 [thread overview]
Message-ID: <20070501170426.GA9376@osiris.ibm.com> (raw)
In-Reply-To: <20070430233309.GH26598@holomorphy.com>
> +static void * __init __alloc_irqstack(int cpu)
> +{
> + if (!cpu)
> + return __alloc_bootmem(THREAD_SIZE, THREAD_SIZE,
> + __pa(MAX_DMA_ADDRESS));
> +
> + return (void *)__get_free_pages(GFP_KERNEL,
> + ilog2(THREAD_SIZE/PAGE_SIZE));
> +}
I think you should test for slab_is_available() instead of checking
if the cpu number is 0.
next prev parent reply other threads:[~2007-05-01 17:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-30 23:23 [0/3] i386 stack handling updates Bill Irwin
2007-04-30 23:33 ` [1/3] dynamically allocate IRQ stacks Bill Irwin
2007-04-30 23:37 ` [2/3] unconditional i386 " Bill Irwin
2007-04-30 23:40 ` [3/3] use vmalloc() to arrange guard pages for stacks Bill Irwin
2007-05-01 15:07 ` Chuck Ebbert
2007-05-01 16:31 ` Bill Irwin
2007-05-01 16:40 ` Chuck Ebbert
2007-05-01 16:47 ` Bill Irwin
2007-05-01 17:04 ` Heiko Carstens [this message]
2007-05-01 17:26 ` [1/3] dynamically allocate IRQ stacks Bill Irwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070501170426.GA9376@osiris.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=bill.irwin@oracle.com \
--cc=bunk@stusta.de \
--cc=dgc@sgi.com \
--cc=eric@provenscaling.com \
--cc=gcoady@gmail.com \
--cc=hch@infradead.org \
--cc=jengelh@linux01.gwdg.de \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=zlynx@acm.org \
--cc=zwane@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.