From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1HizKe-00084A-Va for mharc-grub-devel@gnu.org; Tue, 01 May 2007 16:52:21 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HizKd-00083a-8q for grub-devel@gnu.org; Tue, 01 May 2007 16:52:19 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HizKb-00082j-5r for grub-devel@gnu.org; Tue, 01 May 2007 16:52:18 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HizKb-00082g-2g for grub-devel@gnu.org; Tue, 01 May 2007 16:52:17 -0400 Received: from [212.85.152.101] (helo=kotoba.storever.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HizEF-0004du-Rh for grub-devel@gnu.org; Tue, 01 May 2007 16:45:44 -0400 Received: from kotoba.oasis.nexedi.com (kotoba.oasis.nexedi.com [212.85.152.101]) by kotoba.storever.com (Postfix) with ESMTP id 4FF423D11EDA6 for ; Wed, 2 May 2007 02:43:19 +0200 (CEST) Received: from [??1] (localhost [127.0.0.1]) by kotoba.storever.com (Postfix) with ESMTP id 082DC3D11EDA0 for ; Wed, 2 May 2007 02:43:19 +0200 (CEST) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Tue, 1 May 2007 22:45:39 +0200 User-Agent: KMail/1.8.2 References: <20061015101842.GC4265@khazad.dyndns.org> <200704211538.38367.okuji@enbug.org> <20070429232251.GA2611@aragorn> In-Reply-To: <20070429232251.GA2611@aragorn> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200705012245.39321.okuji@enbug.org> X-Bogosity: No, tests=bogofilter, spamicity=0.000000, version=0.17.2 X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) Subject: Re: update-grub2 patch X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 20:52:19 -0000 On Monday 30 April 2007 01:22, Robert Millan wrote: > On Sat, Apr 21, 2007 at 03:38:38PM +0200, Yoshinori K. Okuji wrote: > > On Tuesday 17 April 2007 14:49, Robert Millan wrote: > > > Here's my patch. Let me know if it's ok for commit. > > > > To include this in the official repository, you need to take care about > > the portability. [...] > > I ported it to bourne shell. It's tested and known to work with dash as > /bin/sh. I think this should address your concern. > > My new patch also arranges the logic for generating update-grub components > to make it more similar to how grub-install is handled. Some issues are still there. You should avoid test -z. Instead, use test x$foo = x. You should avoid ! in test. Use else instead. You should avoid using which. Travese $PATH instead. Okuji