From: Paul Jackson <pj@sgi.com>
To: David Rientjes <rientjes@google.com>
Cc: torvalds@linux-foundation.org, menage@google.com,
clameter@cthulhu.engr.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [patch] cpusets: allow empty {cpus,mems}_allowed to be set for unpopulated cpuset
Date: Wed, 2 May 2007 01:26:47 -0700 [thread overview]
Message-ID: <20070502012647.fbc0d502.pj@sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0705011714490.6376@chino.kir.corp.google.com>
Other than the detail of allowing a newline from doing:
echo > cpus
to work, I'm ok with this patch. It passes my cpuset_test,
and seems to allow unpopulating cpusets, as advertised.
Aha - as I was writing this, I noticed that the command:
echo -n '' > cpus
does -not- work! The echo command recognizes that as a write
of zero non-null bytes, and skips the write altogether.
We have to add the code to handle an input line consisting of
just a bare newline, to mean an empty mask. Well, we don't
-have- to. But writing a single nul byte in shell script will
challenge most shell script hackers.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
prev parent reply other threads:[~2007-05-02 8:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-02 0:16 [patch] cpusets: allow empty {cpus,mems}_allowed to be set for unpopulated cpuset David Rientjes
2007-05-02 3:22 ` Paul Jackson
2007-05-02 3:36 ` Paul Menage
2007-05-02 7:10 ` Paul Jackson
2007-05-02 7:25 ` Paul Jackson
2007-05-02 8:26 ` Paul Jackson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070502012647.fbc0d502.pj@sgi.com \
--to=pj@sgi.com \
--cc=clameter@cthulhu.engr.sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.