From: Andi Kleen <ak@suse.de>
To: Juergen Beisert <juergen127@kreuzholzen.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mikael Pettersson <mikpe@it.uu.se>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [1/1] CPU-i386-Geode: Chipset access macros do not work as expected (2nd try)
Date: Wed, 2 May 2007 11:25:28 +0200 [thread overview]
Message-ID: <200705021125.28201.ak@suse.de> (raw)
In-Reply-To: <200705020917.00134.juergen127@kreuzholzen.de>
> Most comments states Cyrix CPUs when they are using the macros. Is anything
> with Cyrix 64 bit relevant? Maybe "include/asm-x86_64/processor.h" is a
> simple copy of "include/asm-i386/processor.h" and nobody delete the unused
> macros?
It was originally deleted but later readded when the MTRR code was merged together.
That's because of i386/kernel/cpu/mtrr/state.c which is compiled on x86-64 too.
If you can move that code into cyrix.c it can be removed. Might be a good opportunity
to clean this up.
> Please keep me informed and I will resend the patch.
I would need an patch against the current ff tree that doesn't break x86-64.
-Andi
next prev parent reply other threads:[~2007-05-02 9:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-30 14:09 [PATCH] [1/1] CPU-i386-Geode: Chipset access macros do not work as expected Mikael Pettersson
2007-04-30 15:33 ` [PATCH] [1/1] CPU-i386-Geode: Chipset access macros do not work as expected (2nd try) Juergen Beisert
2007-05-02 0:48 ` Andrew Morton
2007-05-02 7:16 ` Juergen Beisert
2007-05-02 7:48 ` Andrew Morton
2007-05-02 9:25 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-04-30 15:40 Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705021125.28201.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=juergen127@kreuzholzen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@it.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.