From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1HjBIZ-0002yW-Vl for user-mode-linux-devel@lists.sourceforge.net; Wed, 02 May 2007 02:39:00 -0700 Received: from cantor.suse.de ([195.135.220.2] helo=mx1.suse.de) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1HjBIX-00079K-M3 for user-mode-linux-devel@lists.sourceforge.net; Wed, 02 May 2007 02:38:59 -0700 From: Andi Kleen Date: Wed, 2 May 2007 11:37:48 +0200 References: <20070501182157.GA8348@c2.user-mode-linux.org> In-Reply-To: <20070501182157.GA8348@c2.user-mode-linux.org> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200705021137.48675.ak@novell.com> Subject: Re: [uml-devel] [PATCH 2/6] Create asm-i386/cmpxchg.h List-Id: The user-mode Linux development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: user-mode-linux-devel-bounces@lists.sourceforge.net Errors-To: user-mode-linux-devel-bounces@lists.sourceforge.net To: Jeff Dike Cc: akpm@osdl.org, LKML , uml-devel On Tuesday 01 May 2007 20:21:57 Jeff Dike wrote: > Rearrange the i386 cmpxchg code to allow atomic.h to get it without > needing to include system.h. This kills warnings in the UML build > from atomic.h about implicit declarations of cmpxchg symbols. The > i386 build presumably isn't seeing this because a separate inclusion > of system.h is covering it over. > > The cmpxchg stuff is moved to asm-i386/cmpxchg.h, with an include left > in system.h for the benefit of generic code which expects cmpxchg > there. > > Meanwhile, atomic.h includes cmpxchg.h. Doesn't apply against the latest ff tree. Can you please regenerate, not losing whatever change caused it to reject? -Andi ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992964AbXEBJiz (ORCPT ); Wed, 2 May 2007 05:38:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S2992966AbXEBJiz (ORCPT ); Wed, 2 May 2007 05:38:55 -0400 Received: from cantor.suse.de ([195.135.220.2]:38795 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2992963AbXEBJiy (ORCPT ); Wed, 2 May 2007 05:38:54 -0400 From: Andi Kleen Organization: SUSE Linux Products GmbH, Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg) To: Jeff Dike Subject: Re: [PATCH 2/6] Create asm-i386/cmpxchg.h Date: Wed, 2 May 2007 11:37:48 +0200 User-Agent: KMail/1.9.6 Cc: akpm@osdl.org, LKML , uml-devel References: <20070501182157.GA8348@c2.user-mode-linux.org> In-Reply-To: <20070501182157.GA8348@c2.user-mode-linux.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200705021137.48675.ak@novell.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 01 May 2007 20:21:57 Jeff Dike wrote: > Rearrange the i386 cmpxchg code to allow atomic.h to get it without > needing to include system.h. This kills warnings in the UML build > from atomic.h about implicit declarations of cmpxchg symbols. The > i386 build presumably isn't seeing this because a separate inclusion > of system.h is covering it over. > > The cmpxchg stuff is moved to asm-i386/cmpxchg.h, with an include left > in system.h for the benefit of generic code which expects cmpxchg > there. > > Meanwhile, atomic.h includes cmpxchg.h. Doesn't apply against the latest ff tree. Can you please regenerate, not losing whatever change caused it to reject? -Andi