From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1HjF15-0007r7-L6 for mharc-grub-devel@gnu.org; Wed, 02 May 2007 09:37:11 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HjF11-0007qA-R7 for grub-devel@gnu.org; Wed, 02 May 2007 09:37:07 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HjF10-0007pn-AS for grub-devel@gnu.org; Wed, 02 May 2007 09:37:07 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HjF10-0007pf-4D for grub-devel@gnu.org; Wed, 02 May 2007 09:37:06 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HjEuZ-0007lB-Hc for grub-devel@gnu.org; Wed, 02 May 2007 09:30:28 -0400 Received: from [192.168.10.6] (helo=aragorn) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1HjEuV-0006Wa-C7 for grub-devel@gnu.org; Wed, 02 May 2007 15:30:23 +0200 Received: from rmh by aragorn with local (Exim 4.63) (envelope-from ) id 1HjEvM-0002No-QC for grub-devel@gnu.org; Wed, 02 May 2007 15:31:16 +0200 Date: Wed, 2 May 2007 15:31:16 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20070502133116.GA29394@aragorn> References: <20061015101842.GC4265@khazad.dyndns.org> <200704211538.38367.okuji@enbug.org> <20070429232251.GA2611@aragorn> <200705012245.39321.okuji@enbug.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200705012245.39321.okuji@enbug.org> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: Genre and OS details not recognized. Subject: Re: update-grub2 patch X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 13:37:07 -0000 On Tue, May 01, 2007 at 10:45:39PM +0200, Yoshinori K. Okuji wrote: > On Monday 30 April 2007 01:22, Robert Millan wrote: > > On Sat, Apr 21, 2007 at 03:38:38PM +0200, Yoshinori K. Okuji wrote: > > > On Tuesday 17 April 2007 14:49, Robert Millan wrote: > > > > Here's my patch. Let me know if it's ok for commit. > > > > > > To include this in the official repository, you need to take care about > > > the portability. [...] > > > > I ported it to bourne shell. It's tested and known to work with dash as > > /bin/sh. I think this should address your concern. > > > > My new patch also arranges the logic for generating update-grub components > > to make it more similar to how grub-install is handled. > > Some issues are still there. You should avoid test -z. Instead, use test x$foo > = x. Ok > You should avoid ! in test. Use else instead. Earlier when I read the portability document I was pointed to, I found: "You may use `!' with `test', but not with `if'" Are you sure this change is required? > You should avoid using > which. Travese $PATH instead. Do you mean something like: IFS=: for i in $PATH ; do grub-probe="$i/grub-probe" if test -x $grub-probe ; then break ; fi done ? -- Robert Millan My spam trap is honeypot@aybabtu.com. Note: this address is only intended for spam harvesters. Writing to it will get you added to my black list.