From: David Miller <davem@davemloft.net>
To: kaber@trash.net
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [NETFILTER 02/04]: nf_nat_proto_gre: do not modify/corrupt GREv0 packets through NAT
Date: Thu, 03 May 2007 03:34:59 -0700 (PDT) [thread overview]
Message-ID: <20070503.033459.75756192.davem@davemloft.net> (raw)
In-Reply-To: <20070503012440.12818.75627.sendpatchset@localhost.localdomain>
From: Patrick McHardy <kaber@trash.net>
Date: Thu, 3 May 2007 03:25:59 +0200 (MEST)
> [NETFILTER]: nf_nat_proto_gre: do not modify/corrupt GREv0 packets through NAT
>
> While porting some changes of the 2.6.21-rc7 pptp/proto_gre conntrack
> and nat modules to a 2.4.32 kernel I noticed that the gre_key function
> returns a wrong pointer to the GRE key of a version 0 packet thus
> corrupting the packet payload.
>
> The intended behaviour for GREv0 packets is to act like
> nf_conntrack_proto_generic/nf_nat_proto_unknown so I have ripped the
> offending functions (not used anymore) and modified the
> nf_nat_proto_gre modules to not touch version 0 (non PPTP) packets.
>
> Signed-off-by: Jorge Boncompte <jorge@dti2.net>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
Applied.
next prev parent reply other threads:[~2007-05-03 10:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-03 1:25 [NETFILTER 00/04]: Netfilter update Patrick McHardy
2007-05-03 1:25 ` [NETFILTER 01/04]: ipt_DNAT: accept port randomization option Patrick McHardy
2007-05-03 10:34 ` David Miller
2007-05-03 1:25 ` [NETFILTER 02/04]: nf_nat_proto_gre: do not modify/corrupt GREv0 packets through NAT Patrick McHardy
2007-05-03 10:34 ` David Miller [this message]
2007-05-03 1:26 ` [NETFILTER 03/04]: sip: Fix RTP address NAT Patrick McHardy
2007-05-03 10:35 ` David Miller
2007-05-03 1:26 ` [NETFILTER 04/04]: bridge netfilter: consolidate header pushing/pulling code Patrick McHardy
2007-05-03 10:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070503.033459.75756192.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.