From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1767397AbXECFjH (ORCPT ); Thu, 3 May 2007 01:39:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1767398AbXECFjH (ORCPT ); Thu, 3 May 2007 01:39:07 -0400 Received: from nz-out-0506.google.com ([64.233.162.230]:9609 "EHLO nz-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1767397AbXECFjF (ORCPT ); Thu, 3 May 2007 01:39:05 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:from:to:cc:subject:message-id:reply-to:mail-followup-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=AxWlkbWDiS049lgFfZwqMLoisC1WpWjHU0SxQ2hrFIXxUJ2L110H6Cvx/I8nearo2KlQBPzvRz4JJNCTJM2+EqKyw+LplFg7KX0P9yi7DSDE6ylZPDQ/F6MgRTFv9kRruHBqmG6c4J9MiB/UzD7xCAOMOlFWRJAvclOsRDqOec4= Date: Thu, 3 May 2007 13:43:38 +0800 From: WANG Cong To: Rusty Russell Cc: lkml - Kernel Mailing List , virtualization Subject: Re: [RELEASE] Lguest for 2.6.21 Message-ID: <20070503054338.GB3166@localhost.localdomain> Reply-To: WANG Cong Mail-Followup-To: Rusty Russell , lkml - Kernel Mailing List , virtualization References: <1178117028.19815.14.camel@localhost.localdomain> <20070502193303.GA1502@localhost.localdomain> <1178146848.23670.6.camel@localhost.localdomain> <20070503035749.GC2295@localhost.localdomain> <1178166032.23670.16.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1178166032.23670.16.camel@localhost.localdomain> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 03, 2007 at 02:20:32PM +1000, Rusty Russell wrote: >On Thu, 2007-05-03 at 11:57 +0800, WANG Cong wrote: >> On Thu, May 03, 2007 at 09:00:48AM +1000, Rusty Russell wrote: >> > Thanks for the patch. This omission (in several places) was >> >deliberate. We can't really do anything sensible if the user unmapped >> >the page. I assume you saw a gcc warning from this code? >> >> Yes. In fact, I got two warnings, another one is in drivers/lguest/hypercalls.c. >> >> If I understand you correctly, you mean we can do nothing useful to fix it? > >We can, but we can ignore those warnings for the moment; they're >harmless. OK. > >> I have sent a mail which described the errors I got when comipling >> Documentation/lguest/lguest.c. But it seems that you didn't receive it >> (it didn't appear in lkml.org neither!). > >Hmm, no, I didn't get it here either 8( > >> It is that, I have already made my .config as you suggested, but I >> still can't compile Documentation/lguest/lguest.c, errors are: >> >> lguest.c: In function 'add_to_bridge': >> lguest.c:779: error: 'SIOCBRADDIF' undeclared (first use in this function) >> lguest.c:779: error: (Each undeclared identifier is reported only once >> lguest.c:779: error: for each function it appears in.) > >Ah, perhaps older libc headers? Can you try adding this to the top of >Documentation/lguest/lguest.c after the #define BRIDGE_PFX "bridge:" > >#ifndef SIOCBRADDIF >#define SIOCBRADDIF 0x89a2 /* add interface to bridge */ >#endif > >Thanks, >Rusty. Yes, it works. Thanks very much for your pointing. I have already found you also forgot some checking in this user-space code. I will fix them soon. ;) Regards. WANG Cong