Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

[Rodolfo Giometti <giometti@enneenne.com>]

On Wed, May 02, 2007 at 02:06:53PM -0700, john stultz wrote:
> 
> Please inline your patch, rather then attaching them. It makes it very
> difficult to discuss when it is attached.

Ok.

> > +++ b/drivers/pps/clients/ktimer.c
> > @@ -0,0 +1,106 @@
> > +/*
> > + * ktimer.c -- kernel timer test client
> > + *
> 
> Could you use a better name, like pps_ktimer_test.c, so it is less generic?

Ok. But consider that this is just a testing program.

> Same goes for your kabi.c and sysfs.c files.

Why? These files don't generate .ko files.

> > @@ -2004,6 +2004,8 @@ serial8250_set_termios(struct uart_port *port, struct ktermios *termios,
> >  		up->ier |= UART_IER_MSI;
> >  	if (up->capabilities & UART_CAP_UUE)
> >  		up->ier |= UART_IER_UUE | UART_IER_RTOIE;
> > +	if (up->port.flags & UPF_HARDPPS_CD)
> > +		up->ier |= UART_IER_MSI;	/* enable interrupts */
> > 
> 
> This isn't covered by a #ifdef, so is this always safe? Should it be in
> a separate patch?

No, this part is regarding the serial driver itself. Maybe it can be
placed in a separate patch but it is still about the PPS support for
Linux...

> Unfortunately I don't have any hardware to play with this, but I'd
> suggest you send this to Andrew Morton for inclusion into his tree for
> testing.

I'll do it.

Thanks,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti@enneenne.com
Linux Device Driver                             giometti@gnudd.com
Embedded Systems                     		giometti@linux.it
UNIX programming                     phone:     +39 349 2432127