From: Russell King <rmk+lkml@arm.linux.org.uk>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-scsi@vger.kernel.org
Subject: Re: dead CONFIG_ variables: drivers/scsi/
Date: Thu, 3 May 2007 12:22:50 +0100 [thread overview]
Message-ID: <20070503112250.GE12018@flint.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.0705030713210.680@localhost.localdomain>
On Thu, May 03, 2007 at 07:17:34AM -0400, Robert P. J. Day wrote:
> p.s. "CONFIG_" prefix aside, i would think it's also a bit yucky to
> be checking for the definition of a preprocessor symbol that you've
> already hardcoded out of existence in the same source file. :-)
No, because the way you turn them on (as intended) is to do:
perl -pi -e 's/undef/define/ if m/CONFIG_ACORNSCSI_CONSTANTS/' \
drivers/scsi/arm/acornscsi.c
(or via your text editor).
An alternative way around the issue is to keep a separate patch
outside of mainline which patches the additional code and data into
the driver. That's far less maintainable, and leads to additional
problems.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2007-05-03 11:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-03 10:10 dead CONFIG_ variables: drivers/scsi/ Robert P. J. Day
2007-05-03 11:11 ` Russell King
2007-05-03 11:17 ` Robert P. J. Day
2007-05-03 11:22 ` Russell King [this message]
2007-05-03 11:35 ` Stefan Richter
2007-05-03 14:15 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070503112250.GE12018@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.