From: Andrew Morton <akpm@linux-foundation.org>
To: Stas Sergeev <stsp@aknet.ru>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Linux kernel <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [patch] export hrtimer_forward
Date: Thu, 3 May 2007 16:58:00 -0700 [thread overview]
Message-ID: <20070503165800.5b7cd3fd.akpm@linux-foundation.org> (raw)
In-Reply-To: <463A338A.2010909@aknet.ru>
On Thu, 03 May 2007 23:10:02 +0400
Stas Sergeev <stsp@aknet.ru> wrote:
> Hello.
>
> Peter Zijlstra wrote:
> >> It seems hrtimer_forward was forgotten to
> >> export - other symbols of the hrtimers API
> > Are there actual in-tree users of this symbol? Without we usually leave
> > the symbol unexported, this saves some space.
> Do you mean it was really left intentional?
> Unbeleivable! But why the other parts of a
> hrtimer API are exported nevertheless, and
> only this particular function not?
It was probably an oversight - generally we take the position that all the
formal interface of a subsystem is exported to modules rather than a
piecemeal whichever-bits-kernel.org-happens-to-use-today approach.
Thomas, is hrtimer_forward() considered part of the hrtimer public API?
And are you OK with the patch?
> As for the users - I am porting my pcsp driver to
> it and I need that function.
> It is not exactly in-tree stuff, but it was
> in an ALSA tree for years already, so it is a
> close one.
next prev parent reply other threads:[~2007-05-03 23:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-03 17:57 [patch] export hrtimer_forward Stas Sergeev
2007-05-03 18:57 ` Peter Zijlstra
2007-05-03 19:10 ` Stas Sergeev
2007-05-03 23:58 ` Andrew Morton [this message]
2007-05-04 21:08 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070503165800.5b7cd3fd.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=stsp@aknet.ru \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.