From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1HjjCe-00086x-Pq for mharc-grub-devel@gnu.org; Thu, 03 May 2007 17:51:08 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HjjCd-00084j-DS for grub-devel@gnu.org; Thu, 03 May 2007 17:51:07 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HjjCb-0007yE-6e for grub-devel@gnu.org; Thu, 03 May 2007 17:51:06 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HjjCa-0007xn-RT for grub-devel@gnu.org; Thu, 03 May 2007 17:51:04 -0400 Received: from [212.85.152.101] (helo=kotoba.storever.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Hjj61-0005bF-1s for grub-devel@gnu.org; Thu, 03 May 2007 17:44:17 -0400 Received: from kotoba.oasis.nexedi.com (kotoba.oasis.nexedi.com [212.85.152.101]) by kotoba.storever.com (Postfix) with ESMTP id CA5EC3D124B31 for ; Fri, 4 May 2007 03:42:45 +0200 (CEST) Received: from [??1] (localhost [127.0.0.1]) by kotoba.storever.com (Postfix) with ESMTP id 991F33D124B2F for ; Fri, 4 May 2007 03:42:45 +0200 (CEST) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Thu, 3 May 2007 23:44:14 +0200 User-Agent: KMail/1.8.2 References: <20061015101842.GC4265@khazad.dyndns.org> <20070502133116.GA29394@aragorn> <20070503154839.GA4030@aragorn> In-Reply-To: <20070503154839.GA4030@aragorn> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200705032344.14824.okuji@enbug.org> X-Bogosity: No, tests=bogofilter, spamicity=0.000000, version=0.17.2 X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) Subject: Re: update-grub2 patch X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 21:51:07 -0000 On Thursday 03 May 2007 17:48, Robert Millan wrote: > On Wed, May 02, 2007 at 03:31:16PM +0200, Robert Millan wrote: > > > You should avoid ! in test. Use else instead. > > > > Earlier when I read the portability document I was pointed to, I found: > > > > "You may use `!' with `test', but not with `if'" > > > > Are you sure this change is required? > > Well, since this is just one line, I fixed it. > > Attached new patch fixes all three problems ('which', 'test !' and 'test > -z|-n') and also adds code in 00_header.in to enable gfxterm when the > unicode font is found in /boot/grub. > > Let me know if everything is ok now.. OK. Please go ahead. Thanks, Okuji