All of lore.kernel.org
 help / color / mirror / Atom feed
From: olof@lixom.net (Olof Johansson)
To: Arnd Bergmann <arnd@arndb.de>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH v2] powerpc: Show current speed in /proc/cpuinfo
Date: Thu, 3 May 2007 22:15:15 -0500	[thread overview]
Message-ID: <20070504031515.GA5567@lixom.net> (raw)
In-Reply-To: <200705020148.07954.arnd@arndb.de>

On Wed, May 02, 2007 at 01:48:07AM +0200, Arnd Bergmann wrote:
> On Monday 30 April 2007, Olof Johansson wrote:
> > On other architectures, the frequency in /proc/cpuinfo moves with cpufreq
> > changes. It makes sense to do the same on powerpc to keep users from
> > getting confused.
> > 
> > Change the format to three decimals, having full Hz granularity is silly
> > these days. Also specify in output if it's cpufreq or firmware-reported:
> > 
> > clock ? ? ? ? ? : 1250.000MHz (from firmware)
> > or:
> > clock ? ? ? ? ? : 2500.000MHz (actual speed)
> 
> 
> Good idea, but I'd be _very_ careful with changing any field in
> /proc/cpuinfo. Having the extra text in there can easily confuse
> parsers in poorly written user applications, maybe even in good ones ;-)
> 
> How about rather adding a new line in there for one of the fields, either

Yeah, good point. Actually, taking away the extra decimals is maybe a
bad idea as well.

I'll settle for clock/current-clock. See patch posted separately.


Thanks,

Olof

  reply	other threads:[~2007-05-04  3:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-27  8:41 [PATCH] powerpc: Show current speed in /proc/cpuinfo Olof Johansson
2007-04-27  9:00 ` Matt Sealey
2007-04-27  9:25   ` Benjamin Herrenschmidt
2007-04-27 18:14   ` Olof Johansson
2007-04-27  9:24 ` Benjamin Herrenschmidt
2007-04-27 17:51   ` Olof Johansson
2007-04-30  3:53 ` [PATCH v2] " Olof Johansson
2007-05-01 23:48   ` Arnd Bergmann
2007-05-04  3:15     ` Olof Johansson [this message]
2007-05-04  3:16   ` [PATCH v3] " Olof Johansson
2007-05-04  3:39     ` Stephen Rothwell
2007-05-04  3:46       ` Olof Johansson
2007-05-04  4:00     ` Paul Mackerras
2007-05-04  4:39       ` [PATCH] pasemi: update ppc_proc_freq from cpufreq driver Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070504031515.GA5567@lixom.net \
    --to=olof@lixom.net \
    --cc=arnd@arndb.de \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.