From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Hjs5o-0001mN-8P for mharc-grub-devel@gnu.org; Fri, 04 May 2007 03:20:40 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Hjs5m-0001m9-1z for grub-devel@gnu.org; Fri, 04 May 2007 03:20:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Hjs5j-0001ku-Jj for grub-devel@gnu.org; Fri, 04 May 2007 03:20:36 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hjs5j-0001kr-DC for grub-devel@gnu.org; Fri, 04 May 2007 03:20:35 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Hjrz6-0001a6-Rv for grub-devel@gnu.org; Fri, 04 May 2007 03:13:45 -0400 Received: from [192.168.10.6] (helo=aragorn) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1Hjrz5-0003J9-LJ for grub-devel@gnu.org; Fri, 04 May 2007 09:13:44 +0200 Received: from rmh by aragorn with local (Exim 4.63) (envelope-from ) id 1Hjs06-00035j-C7 for grub-devel@gnu.org; Fri, 04 May 2007 09:14:46 +0200 Date: Fri, 4 May 2007 09:14:46 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20070504071446.GA9600@aragorn> References: <20061015101842.GC4265@khazad.dyndns.org> <20070502133116.GA29394@aragorn> <20070503154839.GA4030@aragorn> <200705032344.14824.okuji@enbug.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200705032344.14824.okuji@enbug.org> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: Genre and OS details not recognized. Subject: Re: update-grub2 patch X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 07:20:38 -0000 On Thu, May 03, 2007 at 11:44:14PM +0200, Yoshinori K. Okuji wrote: > On Thursday 03 May 2007 17:48, Robert Millan wrote: > > On Wed, May 02, 2007 at 03:31:16PM +0200, Robert Millan wrote: > > > > You should avoid ! in test. Use else instead. > > > > > > Earlier when I read the portability document I was pointed to, I found: > > > > > > "You may use `!' with `test', but not with `if'" > > > > > > Are you sure this change is required? > > > > Well, since this is just one line, I fixed it. > > > > Attached new patch fixes all three problems ('which', 'test !' and 'test > > -z|-n') and also adds code in 00_header.in to enable gfxterm when the > > unicode font is found in /boot/grub. > > > > Let me know if everything is ok now.. > > OK. Please go ahead. Done! -- Robert Millan My spam trap is honeypot@aybabtu.com. Note: this address is only intended for spam harvesters. Writing to it will get you added to my black list.