From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Hk6wF-0005B1-H8 for mharc-grub-devel@gnu.org; Fri, 04 May 2007 19:11:47 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Hk6wD-00059W-NI for grub-devel@gnu.org; Fri, 04 May 2007 19:11:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Hk6wB-000589-Rb for grub-devel@gnu.org; Fri, 04 May 2007 19:11:45 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hk6wB-000584-Mp for grub-devel@gnu.org; Fri, 04 May 2007 19:11:43 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Hk6pU-0001Gb-Rs for grub-devel@gnu.org; Fri, 04 May 2007 19:04:49 -0400 Received: from [192.168.10.6] (helo=aragorn) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1Hk6pT-0004EN-K6 for grub-devel@gnu.org; Sat, 05 May 2007 01:04:48 +0200 Received: from rmh by aragorn with local (Exim 4.63) (envelope-from ) id 1Hk6qZ-0004ZW-8U for grub-devel@gnu.org; Sat, 05 May 2007 01:05:55 +0200 Date: Sat, 5 May 2007 01:05:55 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20070504230555.GA17479@aragorn> References: <20070501191808.GA19766@aragorn> <871whxouby.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871whxouby.fsf@xs4all.nl> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: Genre and OS details not recognized. Subject: Re: GPT on PC/BIOS computers X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 23:11:46 -0000 On Fri, May 04, 2007 at 10:40:17AM +0200, Marco Gerards wrote: > Robert Millan writes: > > > Here's a patch to enable GPT support for PC/BIOS systems. Need for GPT is > > increasingly common due availability of > 2 TiB hard drives. > > > > Please let me know if everything is correct. > > > > Some testing would be welcome, too (but be careful, earlier versions of my > > patch had a "feature" that fucked up your partition table - hopefuly fixed > > now, at least Works For Me [tm]). > > Have you tested it on MBR? Good idea. I have now, and seems to work fine. > > * conf/i386-pc.mk: Regenerate. > > No need to mention this. Ok, removed. > You don't mention in which function you do these things, just the > files. Can you correct this? I personally would prefer if you do not > split up the changelog entries for one file, perhaps it is not even > allowed by the GCS. The later adds a bit of redundancy, but as you prefer. All these are corrected. > > -# Typically, _chain and pc are required. > > -modules="$modules $fs_module _chain pc" > > +# Typically, _chain, pc and gpt are required. > > +modules="$modules $fs_module _chain pc gpt" > > It would be nice if we were able to use grub-probe to determine > this... But for now this is fine, I think. I've looked into this, but I need some advice. What's the simplest way to obtain the corresponding grub_partition_t structure for a partition by knowing its drive name? -- Robert Millan My spam trap is honeypot@aybabtu.com. Note: this address is only intended for spam harvesters. Writing to it will get you added to my black list.