From: Randy Dunlap <randy.dunlap@oracle.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org,
bryan.wu@analog.com, netdev <netdev@vger.kernel.org>
Subject: Re: [patch 089/181] Blackfin: on-chip ethernet MAC controller driver
Date: Sun, 6 May 2007 20:40:41 -0700 [thread overview]
Message-ID: <20070506204041.db0ff08a.randy.dunlap@oracle.com> (raw)
In-Reply-To: <463E70D8.6000403@garzik.org>
On Sun, 06 May 2007 20:20:40 -0400 Jeff Garzik wrote:
> akpm@linux-foundation.org wrote:
> > From: "Wu, Bryan" <bryan.wu@analog.com>
> >
> > This patch implements the driver necessary use the Analog Devices
> > Blackfin processor's on-chip ethernet MAC controller.
> >
> > Signed-off-by: Bryan Wu <bryan.wu@analog.com>
> > Cc: Jeff Garzik <jeff@garzik.org>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > ---
> >
> > drivers/net/Kconfig | 44 +
> > drivers/net/Makefile | 1
> > drivers/net/bfin_mac.c | 981 +++++++++++++++++++++++++++++++++++++++
> > drivers/net/bfin_mac.h | 147 +++++
> > 4 files changed, 1173 insertions(+)
>
> WTF?
>
> Why are new network drivers not going to me, netdev, and/or DaveM?
because people are dumping Everything to lkml :(
> Something is really broken here. What is it?
Use netdev, linux-scsi, linux-ide, linux-usb-devel, linux-ieee1394,
etc., instead of one-list-fits-all.
> I NAK this driver purely on the basis of lack of review.
Yep.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2007-05-07 3:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200705062150.l46LoVWQ024648@shell0.pdx.osdl.net>
2007-05-07 0:20 ` [patch 089/181] Blackfin: on-chip ethernet MAC controller driver Jeff Garzik
2007-05-07 3:40 ` Randy Dunlap [this message]
2007-05-23 8:30 ` Bryan Wu
2007-05-23 9:13 ` Jeff Garzik
2007-05-23 9:16 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070506204041.db0ff08a.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bryan.wu@analog.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.