From: Michael Buesch <mb@bu3sch.de>
To: Michael Wu <flamingice@sourmilk.net>
Cc: Jiri Benc <jbenc@suse.cz>, John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Allow sleeping in set_key op
Date: Mon, 7 May 2007 22:50:42 +0200 [thread overview]
Message-ID: <200705072250.42407.mb@bu3sch.de> (raw)
In-Reply-To: <200705071517.21331.flamingice@sourmilk.net>
On Monday 07 May 2007 21:17:14 Michael Wu wrote:
> On Sunday 06 May 2007 14:37, Michael Buesch wrote:
> > Allow drivers to sleep in the setkey function, as it's rather
> > complicated to defer set_key to a workqueue in the driver
> > (error code is lost, keyconf->hw_key_idx is possibly hard
> > to get right.)
> >
> I'd rather not defer to a workqueue. That just patches over the awkward
> locking that the sta_info code has, which is really the reason why you can't
> sleep in set_key.
Well, but it seems nobody is fixing the locking. I was told it's
almost impossible or something like that. ;)
This is just trying to fix showstopper bugs for bcm43xx.
--
Greetings Michael.
prev parent reply other threads:[~2007-05-07 20:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-06 18:37 [PATCH] mac80211: Allow sleeping in set_key op Michael Buesch
2007-05-07 16:52 ` Jiri Benc
2007-05-07 20:44 ` Michael Buesch
2007-05-14 17:37 ` Jiri Benc
2007-05-14 17:47 ` Michael Buesch
2007-05-07 19:17 ` Michael Wu
2007-05-07 20:50 ` Michael Buesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705072250.42407.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.