Re: [PATCH v2 6/7] Holly DTS

[David Gibson <dwg@au1.ibm.com>]

On Mon, May 07, 2007 at 08:11:52AM -0500, Josh Boyer wrote:
> On Sun, 2007-05-06 at 10:40 +1000, David Gibson wrote:
> > On Sat, May 05, 2007 at 07:21:33PM +0200, Segher Boessenkool wrote:
> > [snip]
> > > > +	compatible = "ppc750-tsi";
> > > 
> > > The needs to be more specific as well; "ibm,holly"
> > > or something.
> > 
> > Or perhaps just include something more specific, compatible can have
> > the general version as well.
> > 
> > [snip]
> > > > +	chosen {
> > > > +		linux,platform = <0>;
> > > > +		linux,initrd-start = <0>;
> > > > +		linux,initrd-end = <0>;
> > > 
> > > Do you need to set those zero properties?
> > 
> > linux,platform is obsolete and should definitely go.  With the recent
> > bootloader updates the initrd properties can also go (the bootloader
> > will add them correctly).  I had them in the Ebony device tree until
> > very recently because until some of the recent flatdevtree.c fixes,
> > the bootloader could replace the value of the properties, but it
> > couldn't add new properties (or at least not properties with new
> > names).
> 
> s/bootloader/bootwrapper?

Yes.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson