From: Theodore Tso <tytso@mit.edu>
To: Kalpak Shah <kalpak@clusterfs.com>
Cc: linux-ext4 <linux-ext4@vger.kernel.org>,
Andreas Dilger <adilger@clusterfs.com>
Subject: Re: [PATCH] e2fsprogs: Check journal inode sanity and recreate journal
Date: Tue, 8 May 2007 01:40:34 -0400 [thread overview]
Message-ID: <20070508054034.GA28110@thunk.org> (raw)
In-Reply-To: <1173906827.3076.5.camel@garfield>
On Thu, Mar 15, 2007 at 02:43:47AM +0530, Kalpak Shah wrote:
> Index: e2fsprogs-1.39/lib/ext2fs/mkjournal.c
> ===================================================================
> --- e2fsprogs-1.39.orig/lib/ext2fs/mkjournal.c
> +++ e2fsprogs-1.39/lib/ext2fs/mkjournal.c
> + if (fs->super->s_blocks_count < 2048) {
> + fputs(("\nFilesystem too small for a journal\n"), stderr);
> + return 0;
> + }
Code in lib/ext2fs isn't allowed to do any output to stdio (except for
debugging purposes). It causes internationalization problems, and
it's just in general a bad idea for ext2fs library code to try to do
any UI.
- Ted
next prev parent reply other threads:[~2007-05-08 5:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-14 21:13 [PATCH] e2fsprogs: Check journal inode sanity and recreate journal Kalpak Shah
2007-05-08 5:40 ` Theodore Tso [this message]
2007-05-24 21:22 ` Kalpak Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070508054034.GA28110@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@clusterfs.com \
--cc=kalpak@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.