From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] coretemp add more safety checks
Date: Tue, 08 May 2007 09:35:45 +0000 [thread overview]
Message-ID: <20070508113545.5ca31f4f@hyperion.delvare> (raw)
In-Reply-To: <4634A411.4030703@assembler.cz>
Hi Rudolf,
On Sun, 29 Apr 2007 15:56:33 +0200, Rudolf Marek wrote:
> I hope I will have more time from now, here my patch. It adds check for Errata
> AE18 of core processors, which causes values not to update after the CPU deep
> sleeps. Intel claims that the TjMax detection might not work for the Core2, warn
> the users about this.
>
> I would like to ask anyone using coretemp on notebook to test this patch!
>
> In case it is ok (haha) here is the kernel stuff:
>
> Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
>
> This patch adds detection of AE18 Errata of Core processor and warns
> users that the absolute readings might be wrong for Core2 users.
Your patch:
* Doesn't apply on top of the version of the coretemp driver I have on
my hwmon stack [1].
* Once manually fixed to apply, fails to compile.
[1] http://khali.linux-fr.org/devel/linux-2.6/jdelvare-hwmon/hwmon-coretemp-new-driver.patch
Can you please provide a patch which at least applies and compiles, so
that users have a chance to test it? Other than that, it looks good.
Please resubmit. Thanks.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2007-05-08 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-29 13:56 [lm-sensors] [PATCH] coretemp add more safety checks Rudolf Marek
2007-05-08 9:35 ` Jean Delvare [this message]
2007-05-10 22:39 ` Rudolf Marek
2007-05-13 11:51 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070508113545.5ca31f4f@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.