All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: Nick Piggin <npiggin@suse.de>
Cc: linux-arch@vger.kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [rfc] lock bitops
Date: Tue, 8 May 2007 09:06:32 -0600	[thread overview]
Message-ID: <20070508150631.GC10562@parisc-linux.org> (raw)
In-Reply-To: <20070508113709.GA19294@wotan.suse.de>

On Tue, May 08, 2007 at 01:37:09PM +0200, Nick Piggin wrote:
> --
> Introduce test_and_set_bit_lock / clear_bit_unlock bitops with lock semantics.
> Add non-trivial for powerpc and ia64. Convert page lock, buffer lock,
> bit_spin_lock, tasklet locks to use the new locks.

The names are a bit clumsy.  How about naming them after the effect,
rather than the implementation?  It struck me that really these things
are bit mutexes -- you can sleep while holding the lock.  How about
calling them bit_mutex_trylock() and bit_mutex_unlock()?


  parent reply	other threads:[~2007-05-08 15:06 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-08 11:37 [rfc] lock bitops Nick Piggin
2007-05-08 11:40 ` [rfc] optimise unlock_page Nick Piggin
2007-05-08 11:40   ` Nick Piggin
2007-05-08 12:13   ` David Howells
2007-05-08 12:13     ` David Howells
2007-05-08 22:35     ` Nick Piggin
2007-05-08 22:35       ` Nick Piggin
2007-05-08 20:08   ` Hugh Dickins
2007-05-08 20:08     ` Hugh Dickins
2007-05-08 21:30   ` Benjamin Herrenschmidt
2007-05-08 21:30     ` Benjamin Herrenschmidt
2007-05-08 22:41     ` Nick Piggin
2007-05-08 22:41       ` Nick Piggin
2007-05-08 22:50       ` Nick Piggin
2007-05-08 22:50         ` Nick Piggin
2007-05-09 19:33         ` Hugh Dickins
2007-05-09 19:33           ` Hugh Dickins
2007-05-09 21:21           ` Benjamin Herrenschmidt
2007-05-09 21:21             ` Benjamin Herrenschmidt
2007-05-10  3:37           ` Nick Piggin
2007-05-10  3:37             ` Nick Piggin
2007-05-10 19:14             ` Hugh Dickins
2007-05-10 19:14               ` Hugh Dickins
2007-05-11  8:54               ` Nick Piggin
2007-05-11  8:54                 ` Nick Piggin
2007-05-11 13:15                 ` Hugh Dickins
2007-05-11 13:15                   ` Hugh Dickins
2007-05-13  3:32                   ` Nick Piggin
2007-05-13  3:32                     ` Nick Piggin
2007-05-13  4:39                     ` Hugh Dickins
2007-05-13  4:39                       ` Hugh Dickins
2007-05-13  6:52                       ` Nick Piggin
2007-05-13  6:52                         ` Nick Piggin
2007-05-16 17:54                         ` Hugh Dickins
2007-05-16 17:54                           ` Hugh Dickins
2007-05-16 18:18                           ` Nick Piggin
2007-05-16 18:18                             ` Nick Piggin
2007-05-16 19:28                             ` Hugh Dickins
2007-05-16 19:28                               ` Hugh Dickins
2007-05-16 19:47                               ` Linus Torvalds
2007-05-16 19:47                                 ` Linus Torvalds
2007-05-17  6:27                                 ` Nick Piggin
2007-05-17  6:27                                   ` Nick Piggin
2007-05-16 17:21                     ` Hugh Dickins
2007-05-16 17:21                       ` Hugh Dickins
2007-05-16 17:38                       ` Nick Piggin
2007-05-16 17:38                         ` Nick Piggin
2007-05-08 12:22 ` [rfc] lock bitops David Howells
2007-05-08 22:33   ` Nick Piggin
2007-05-09  6:18   ` Nick Piggin
2007-05-08 15:06 ` Matthew Wilcox [this message]
2007-05-08 21:23   ` Benjamin Herrenschmidt
2007-05-08 22:29   ` Nick Piggin
2007-05-08 22:40     ` Matthew Wilcox
2007-05-08 22:45       ` Nick Piggin
2007-05-09 12:08 ` Nikita Danilov
2007-05-09 12:20   ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070508150631.GC10562@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npiggin@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.