From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] update mach-omap2/pm.c for struct subsystem removal
Date: Tue, 8 May 2007 14:48:03 -0700 [thread overview]
Message-ID: <20070508214802.GN32547@atomide.com> (raw)
In-Reply-To: <20070508213943.119220524@pwsan.com>
* Paul Walmsley <paul@pwsan.com> [070508 14:41]:
> 'struct subsystem' is no more, replaced with 'struct kset': commit
> 823bccfc4002296ba88c3ad0f049e1abd8108d30. Fixes the following
> warnings:
>
> CC arch/arm/mach-omap2/pm.o
> arch/arm/mach-omap2/pm.c:410: warning: 'struct subsystem' declared inside parameter list
> arch/arm/mach-omap2/pm.c:410: warning: its scope is only this definition or declaration, which is probably not what you want
> arch/arm/mach-omap2/pm.c:417: warning: 'struct subsystem' declared inside parameter list
> arch/arm/mach-omap2/pm.c:434: warning: initialization from incompatible pointer type
> arch/arm/mach-omap2/pm.c:435: warning: initialization from incompatible pointer type
>
> Compile-tested only.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
>
> ---
> arch/arm/mach-omap2/pm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-omap-2.6/arch/arm/mach-omap2/pm.c
> ===================================================================
> --- linux-omap-2.6.orig/arch/arm/mach-omap2/pm.c
> +++ linux-omap-2.6/arch/arm/mach-omap2/pm.c
> @@ -407,12 +407,12 @@ static inline void serial_console_fclk_m
>
> static unsigned short enable_dyn_sleep = 0; /* disabled till drivers are fixed */
>
> -static ssize_t omap_pm_sleep_while_idle_show(struct subsystem * subsys, char *buf)
> +static ssize_t omap_pm_sleep_while_idle_show(struct kset * subsys, char *buf)
> {
> return sprintf(buf, "%hu\n", enable_dyn_sleep);
> }
>
> -static ssize_t omap_pm_sleep_while_idle_store(struct subsystem * subsys,
> +static ssize_t omap_pm_sleep_while_idle_store(struct kset * subsys,
> const char * buf,
> size_t n)
> {
>
Thanks, pushing today.
Tony
prev parent reply other threads:[~2007-05-08 21:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070508213856.893570384@pwsan.com>
2007-05-08 21:39 ` [PATCH] update mach-omap2/pm.c for struct subsystem removal Paul Walmsley
2007-05-08 21:48 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070508214802.GN32547@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.