From: David Gibson <david@gibson.dropbear.id.au>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: jdl@jdl.com, linuxppc-dev@ozlabs.org, paulus@samba.org,
Olof Johansson <olof@lixom.net>,
arnd@ardnb.de, Timur Tabi <timur@freescale.com>
Subject: Re: Current powerpc.git build failures
Date: Wed, 9 May 2007 11:09:41 +1000 [thread overview]
Message-ID: <20070509010941.GC4198@localhost.localdomain> (raw)
In-Reply-To: <5E47D5F4-DD15-46D1-A947-3031D069486F@kernel.crashing.org>
On Tue, May 08, 2007 at 03:38:35PM -0500, Kumar Gala wrote:
>
> On May 8, 2007, at 3:30 PM, Timur Tabi wrote:
>
> > Olof Johansson wrote:
> >
> >> powerpc.mpc8641_hpcn_defconfig:
> >> In file included from include/asm-generic/pgtable-nopmd.h:6,
> >> from include/asm/pgtable-ppc32.h:4,
> >> from include/asm/pgtable.h:8,
> >> from arch/powerpc/platforms/86xx/mpc86xx_smp.c:18:
> >> include/asm-generic/pgtable-nopud.h:13: error: expected specifier-
> >> qualifier-list before 'pgd_t'
> >
> > This must have occurred in the past 24 hours because I built the
> > latest 8641 yesterday
> > morning and it worked fine. mpc86xx_smp.c has not changed since
> > February, so I'm guessing
> > that some header file that mpc86xx_smp.c includes no longer
> > includes some other header.
>
> I'm guessing this is from david gibson's 4level-fixup.h for ppc32
> patch.
Looks like. AFAICT, the generic nopud.h and nopmd.h headers expect
page.h to be included before pgtable.h. I think this patch should fix
the problem, but I don't have a suitable board to test with.
Index: working-2.6/arch/powerpc/platforms/86xx/mpc86xx_smp.c
===================================================================
--- working-2.6.orig/arch/powerpc/platforms/86xx/mpc86xx_smp.c 2007-05-09 11:08:15.000000000 +1000
+++ working-2.6/arch/powerpc/platforms/86xx/mpc86xx_smp.c 2007-05-09 11:08:33.000000000 +1000
@@ -15,8 +15,8 @@
#include <linux/init.h>
#include <linux/delay.h>
-#include <asm/pgtable.h>
#include <asm/page.h>
+#include <asm/pgtable.h>
#include <asm/pci-bridge.h>
#include <asm-powerpc/mpic.h>
#include <asm/mpc86xx.h>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2007-05-09 1:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 19:17 Current powerpc.git build failures Olof Johansson
2007-05-08 20:30 ` Timur Tabi
2007-05-08 20:38 ` Kumar Gala
2007-05-09 1:09 ` David Gibson [this message]
2007-05-09 1:18 ` Loeliger Jon-LOELIGER
2007-05-09 1:51 ` David Gibson
2007-05-09 1:57 ` David Gibson
2007-05-09 5:20 ` David Gibson
2007-05-08 22:47 ` Vitaly Bordug
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070509010941.GC4198@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=arnd@ardnb.de \
--cc=galak@kernel.crashing.org \
--cc=jdl@jdl.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
--cc=paulus@samba.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.