From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758228AbXEIQ3Y (ORCPT ); Wed, 9 May 2007 12:29:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756029AbXEIQ3H (ORCPT ); Wed, 9 May 2007 12:29:07 -0400 Received: from smtp1.linux-foundation.org ([65.172.181.25]:53286 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756037AbXEIQ3D (ORCPT ); Wed, 9 May 2007 12:29:03 -0400 Date: Wed, 9 May 2007 09:28:53 -0700 From: Andrew Morton To: David Howells Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 3/3] AFS: Implement basic file write support Message-Id: <20070509092853.65619a35.akpm@linux-foundation.org> In-Reply-To: <4815.1178708859@redhat.com> References: <20070509034135.853ae84c.akpm@linux-foundation.org> <20070508170051.eb4751ce.akpm@linux-foundation.org> <20070508194358.27477.74888.stgit@warthog.cambridge.redhat.com> <20070508194411.27477.7552.stgit@warthog.cambridge.redhat.com> <997.1178706347@redhat.com> <4815.1178708859@redhat.com> X-Mailer: Sylpheed 2.4.1 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 09 May 2007 12:07:39 +0100 David Howells wrote: > Andrew Morton wrote: > > > set_page_dirty() will set I_DIRTY_PAGES only. ie: the inode has dirty > > pagecache data. > > > > To tell the VFS that the inode itself is dirty one needs to run > > mark_inode_dirty(). > > But what's the difference in this case? I don't need to write the inode back > per se, and the inode attributes can be updated by the mechanism of data > storage. > Ah. Well if you don't need to write the inode back then sure, there shouldn't be a need to mark it dirty. That's what I was asking ;)