From: Andrew Morton <akpm@linux-foundation.org>
To: Florian Fainelli <florian.fainelli@int-evry.fr>
Cc: linux-kernel@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] time locale in gen_initramfs_list.sh
Date: Wed, 9 May 2007 17:09:26 -0700 [thread overview]
Message-ID: <20070509170926.27fad8bb.akpm@linux-foundation.org> (raw)
In-Reply-To: <200705080755.31157.florian.fainelli@int-evry.fr>
On Tue, 8 May 2007 07:55:26 +0200
Florian Fainelli <florian.fainelli@int-evry.fr> wrote:
> I noticed that some zsh users who forced their ls formatting to something non
> standard could not generate the initramfs file list. Forcing the locale to C
> while generating seems not to be enough. Adding --time-style=locale will use
> C locale ls output and will let them generate the initramfs list. It has no
> side effects for other users.
>
> Signed-off-by: Florian Fainelli <florian.fainelli@int-evry.fr>
> --
>
>
> [time_locale.patch text/plain (761B)]
> diff --git a/scripts/gen_initramfs_list.sh b/scripts/gen_initramfs_list.sh
> index 683eb12..1f96b9b 100644
> --- a/scripts/gen_initramfs_list.sh
> +++ b/scripts/gen_initramfs_list.sh
> @@ -125,7 +125,7 @@ parse() {
> str="${ftype} ${name} ${location} ${str}"
> ;;
> "nod")
> - local dev=`LC_ALL=C ls -l "${location}"`
> + local dev=`LC_ALL=C ls --time-style=locale -l "${location}"`
> local maj=`field 5 ${dev}`
> local min=`field 6 ${dev}`
> maj=${maj%,}
> @@ -135,7 +135,7 @@ parse() {
> str="${ftype} ${name} ${str} ${dev} ${maj} ${min}"
> ;;
> "slink")
> - local target=`field 11 $(LC_ALL=C ls -l "${location}")`
> + local target=`field 11 $(LC_ALL=C ls --time-style=locale -l "${location}")`
> str="${ftype} ${name} ${target} ${str}"
> ;;
hm, --time-style sounds rather gnu-specific and perhaps we'd rather not
add that requirement. Or perhaps we already require gnu ls, dunno.
I'll dump the problem in Sam's lap ;)
next prev parent reply other threads:[~2007-05-10 0:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 5:55 [PATCH] time locale in gen_initramfs_list.sh Florian Fainelli
2007-05-08 11:06 ` H. Peter Anvin
2007-05-08 14:46 ` Florian Fainelli
2007-05-08 22:34 ` Michael Mauch
2007-05-10 0:09 ` Andrew Morton [this message]
2007-05-10 2:08 ` Rob Landley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070509170926.27fad8bb.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=florian.fainelli@int-evry.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.