From: Andrew Morton <akpm@linux-foundation.org>
To: NeilBrown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 002 of 2] md: Improve the is_mddev_idle test
Date: Thu, 10 May 2007 00:33:04 -0700 [thread overview]
Message-ID: <20070510003304.c5fc35d2.akpm@linux-foundation.org> (raw)
In-Reply-To: <1070510062231.20403@suse.de>
On Thu, 10 May 2007 16:22:31 +1000 NeilBrown <neilb@suse.de> wrote:
> The test currently looks for any (non-fuzz) difference, either
> positive or negative. This clearly is not needed. Any non-sync
> activity will cause the total sectors to grow faster than the sync_io
> count (never slower) so we only need to look for a positive differences.
>
> ...
>
> --- .prev/drivers/md/md.c 2007-05-10 15:51:54.000000000 +1000
> +++ ./drivers/md/md.c 2007-05-10 16:05:10.000000000 +1000
> @@ -5095,7 +5095,7 @@ static int is_mddev_idle(mddev_t *mddev)
> *
> * Note: the following is an unsigned comparison.
> */
> - if ((curr_events - rdev->last_events + 4096) > 8192) {
> + if ((long)curr_events - (long)rdev->last_events > 4096) {
> rdev->last_events = curr_events;
> idle = 0;
In which case would unsigned counters be more appropriate?
next prev parent reply other threads:[~2007-05-10 7:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-10 6:22 [PATCH 000 of 2] md: Two more bugfixes NeilBrown
2007-05-10 6:22 ` NeilBrown
2007-05-10 6:22 ` [PATCH 001 of 2] md: Avoid a possibility that a read error can wrongly propagate through md/raid1 to a filesystem NeilBrown
2007-05-10 6:22 ` NeilBrown
2007-05-10 6:22 ` [PATCH 002 of 2] md: Improve the is_mddev_idle test NeilBrown
2007-05-10 6:22 ` NeilBrown
2007-05-10 7:33 ` Andrew Morton [this message]
2007-05-10 9:46 ` Neil Brown
2007-05-10 9:48 ` Jan Engelhardt
2007-05-10 10:04 ` Neil Brown
2007-05-10 12:52 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070510003304.c5fc35d2.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.