All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Kristian H?gsberg <krh@redhat.com>,
	linux1394-devel <linux1394-devel@lists.sourceforge.net>,
	linux-scsi@vger.kernel.org
Subject: Re: use_sg != 0 assumption (was Re: [PATCH 5/9] Drop single buffer request support.)
Date: Thu, 10 May 2007 12:44:11 +0100	[thread overview]
Message-ID: <20070510114411.GA17971@infradead.org> (raw)
In-Reply-To: <4642F627.5040400@s5r6.in-berlin.de>

On Thu, May 10, 2007 at 12:38:31PM +0200, Stefan Richter wrote:
> >  	fw_memcpy_to_be32(&orb->request, &orb->request, sizeof orb->request);
> >  
> 
> Would a BUG_ON(cmd->use_sg == 0); be in order?

I don't think we should put this into every driver.  If you want to
be sure this doesn't happen anymore put it just in front of the queuecommand
call.

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

  reply	other threads:[~2007-05-10 11:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <11787529952207-git-send-email-krh@redhat.com>
     [not found] ` <11787530023454-git-send-email-krh@redhat.com>
     [not found]   ` <11787530031570-git-send-email-krh@redhat.com>
     [not found]     ` <11787530031450-git-send-email-krh@redhat.com>
     [not found]       ` <11787530043878-git-send-email-krh@redhat.com>
2007-05-10 10:38         ` use_sg != 0 assumption (was Re: [PATCH 5/9] Drop single buffer request support.) Stefan Richter
2007-05-10 11:44           ` Christoph Hellwig [this message]
2007-05-10 13:09             ` Stefan Richter
2007-05-10 13:08           ` Kristian Høgsberg
     [not found]         ` <11787530054176-git-send-email-krh@redhat.com>
2007-05-10 10:44           ` [PATCH 6/9] Make scsi_host_template::proc_name const char * instead of char * Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070510114411.GA17971@infradead.org \
    --to=hch@infradead.org \
    --cc=krh@redhat.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.